build/android/pylib/gtest/test_package_apk.py - Issue 294113003: [Android] Convert to DeviceUtils versions of WaitUntilFullyBooted and GetExternalStoragePath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_apk.py

Issue 294113003: [Android] Convert to DeviceUtils versions of WaitUntilFullyBooted and GetExternalStoragePath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/gtest/test_package_apk.py

diff --git a/build/android/pylib/gtest/test_package_apk.py b/build/android/pylib/gtest/test_package_apk.py

index 9d3dac541ea580c49c464cdfca19238abc94634b..9f077b6b90f8b3047de183d5502a8e71cccd8c8a 100644

--- a/build/android/pylib/gtest/test_package_apk.py

+++ b/build/android/pylib/gtest/test_package_apk.py

@@ -85,9 +85,14 @@ class TestPackageApk(TestPackage):

# Content shell creates a profile on the sdscard which accumulates cache

# files over time.

if self.suite_name == 'content_browsertests':

- device.old_interface.RunShellCommand(

- 'rm -r %s/content_shell' % device.old_interface.GetExternalStorage(),

- timeout_time=60 * 2)

+ try:

+ device.old_interface.RunShellCommand(

+ 'rm -r %s/content_shell' % device.GetExternalStoragePath(),

+ timeout_time=60 * 2)

+ except device_errors.CommandFailedError:

+ # TODO(jbudorick) Handle this exception appropriately once the

+ # conversions are done.

+ pass

#override

def CreateCommandLineFileOnDevice(self, device, test_filter, test_arguments):

« no previous file with comments | « build/android/pylib/device/device_utils_test.py ('k') | build/android/pylib/gtest/test_package_exe.py » ('j') | no next file with comments »