Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2941123004: Remove MemoryCoordinator::CanSuspendRenderer() (Closed)

Created:
3 years, 6 months ago by bashi
Modified:
3 years, 6 months ago
Reviewers:
kinuko, haraken, chrisha, shimazu
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, chrome-grc-reviews+memory_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MemoryCoordinator::CanSuspendRenderer() We no longer have a plan to use this method. We can add it later if we really need this. BUG=696844 Review-Url: https://codereview.chromium.org/2941123004 Cr-Commit-Position: refs/heads/master@{#480329} Committed: https://chromium.googlesource.com/chromium/src/+/b2bea37ff0b2955f79a8d88d87e61e6a82429255

Patch Set 1 #

Patch Set 2 : Remove include #

Total comments: 1

Patch Set 3 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -155 lines) Patch
M chrome/browser/memory/chrome_memory_coordinator_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory/chrome_memory_coordinator_delegate.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 3 chunks +4 lines, -17 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_browsertest.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 1 2 4 chunks +3 lines, -26 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 chunks +0 lines, -65 lines 0 comments Download
M content/public/browser/memory_coordinator_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
bashi
PTAL chrisha@: chrome/browser/memory shimazu@: content/browser/service_worker kinuko@: content/public https://codereview.chromium.org/2941123004/diff/20001/content/public/browser/memory_coordinator_delegate.h File content/public/browser/memory_coordinator_delegate.h (left): https://codereview.chromium.org/2941123004/diff/20001/content/public/browser/memory_coordinator_delegate.h#oldcode23 content/public/browser/memory_coordinator_delegate.h:23: virtual void ...
3 years, 6 months ago (2017-06-16 04:57:09 UTC) #6
shimazu
lgtm
3 years, 6 months ago (2017-06-16 05:03:22 UTC) #7
kinuko
lgtm
3 years, 6 months ago (2017-06-16 05:19:15 UTC) #8
haraken
LGTM
3 years, 6 months ago (2017-06-16 05:37:23 UTC) #9
chrisha
lgtm!
3 years, 6 months ago (2017-06-16 17:00:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941123004/40001
3 years, 6 months ago (2017-06-18 23:51:47 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 01:40:34 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b2bea37ff0b2955f79a8d88d87e6...

Powered by Google App Engine
This is Rietveld 408576698