Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2941123003:
Adjust user pod tab order for new login screen (Closed)
|
Created:
3 years, 6 months ago by Wenzhao (Colin) Zang Modified:
3 years, 6 months ago CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, rkc Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdjust user pod tab order for new login screen
When using 'Tab', the focus should go to the user menu drop down icon right
after the password input field. Due to the implementation the two have the
same tab index, so the easiest way is to switch the position of the two
elements in HTML. The order change doesn't affect any other parts of the
implementation.
BUG=733191
Review-Url: https://codereview.chromium.org/2941123003
Cr-Commit-Position: refs/heads/master@{#480162}
Committed: https://chromium.googlesource.com/chromium/src/+/5328f007181fe5acd3d913e0fa4ada0cb4dff483
Patch Set 1 #
Total comments: 2
Messages
Total messages: 24 (16 generated)
Description was changed from ========== Adjust user pod tab order for new login screen BUG=733191 ========== to ========== Adjust user pod tab order for new login screen When using 'Tab', the focus should go to the user menu drop down icon right after the password input field. Due to the implementation they have the same tab index, so the easiest way is to switch the position of the two elements in HTML. The order change doesn't affect any other codes. BUG=733191 ==========
wzang@chromium.org changed reviewers: + achuith@chromium.org
Description was changed from ========== Adjust user pod tab order for new login screen When using 'Tab', the focus should go to the user menu drop down icon right after the password input field. Due to the implementation they have the same tab index, so the easiest way is to switch the position of the two elements in HTML. The order change doesn't affect any other codes. BUG=733191 ========== to ========== Adjust user pod tab order for new login screen When using 'Tab', the focus should go to the user menu drop down icon right after the password input field. Due to the implementation the two have the same tab index, so the easiest way is to switch the position of the two elements in HTML. The order change doesn't affect any other codes. BUG=733191 ==========
Description was changed from ========== Adjust user pod tab order for new login screen When using 'Tab', the focus should go to the user menu drop down icon right after the password input field. Due to the implementation the two have the same tab index, so the easiest way is to switch the position of the two elements in HTML. The order change doesn't affect any other codes. BUG=733191 ========== to ========== Adjust user pod tab order for new login screen When using 'Tab', the focus should go to the user menu drop down icon right after the password input field. Due to the implementation the two have the same tab index, so the easiest way is to switch the position of the two elements in HTML. The order change doesn't affect any other parts of the implementation. BUG=733191 ==========
achuith@, PTAL. Thanks so much.
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
achuith@chromium.org changed reviewers: + jdufault@chromium.org
Jake, could you PTAL?
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm if my comment is true. https://codereview.chromium.org/2941123003/diff/1/ui/login/account_picker/md_... File ui/login/account_picker/md_user_pod_template.html (right): https://codereview.chromium.org/2941123003/diff/1/ui/login/account_picker/md_... ui/login/account_picker/md_user_pod_template.html:60: <div class="auth-container"> I'm assuming this is just moving code?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2941123003/diff/1/ui/login/account_picker/md_... File ui/login/account_picker/md_user_pod_template.html (right): https://codereview.chromium.org/2941123003/diff/1/ui/login/account_picker/md_... ui/login/account_picker/md_user_pod_template.html:60: <div class="auth-container"> On 2017/06/15 21:47:21, jdufault wrote: > I'm assuming this is just moving code? Yes, purely moving code.
achuith@, could you still take a look as the owner review is missing? Thanks a lot.
lgtm based on Jake's review
The CQ bit was checked by wzang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497646259305440, "parent_rev":
"67287b9222707bb70d8c07f49a2a5c2188827dd3", "commit_rev":
"5328f007181fe5acd3d913e0fa4ada0cb4dff483"}
Message was sent while issue was closed.
Description was changed from ========== Adjust user pod tab order for new login screen When using 'Tab', the focus should go to the user menu drop down icon right after the password input field. Due to the implementation the two have the same tab index, so the easiest way is to switch the position of the two elements in HTML. The order change doesn't affect any other parts of the implementation. BUG=733191 ========== to ========== Adjust user pod tab order for new login screen When using 'Tab', the focus should go to the user menu drop down icon right after the password input field. Due to the implementation the two have the same tab index, so the easiest way is to switch the position of the two elements in HTML. The order change doesn't affect any other parts of the implementation. BUG=733191 Review-Url: https://codereview.chromium.org/2941123003 Cr-Commit-Position: refs/heads/master@{#480162} Committed: https://chromium.googlesource.com/chromium/src/+/5328f007181fe5acd3d913e0fa4a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5328f007181fe5acd3d913e0fa4a... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
