Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2941103002: Adds lite page integration test (ignoring country blacklist). (Closed)

Created:
3 years, 6 months ago by dougarnett
Modified:
3 years, 6 months ago
Reviewers:
megjablon, bustamante
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds lite page integration test (ignoring country blacklist). Also: - removes no longer needed field trial on some lite page integration tests - adds server response checks on new force lofi flag test - annotates the tests than need M-61 or greater. BUG=701802 Review-Url: https://codereview.chromium.org/2941103002 Cr-Commit-Position: refs/heads/master@{#480861} Committed: https://chromium.googlesource.com/chromium/src/+/b8ae3bdd6f625ef983b2615b74f240506dcbde8b

Patch Set 1 #

Patch Set 2 : Fix paste error #

Patch Set 3 : Merge with decorator name change #

Patch Set 4 : Updated lofi force flag test to verify server response now live #

Patch Set 5 : Renames two triggering tests to be less specific wrt actual previews server selects. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -26 lines) Patch
M tools/chrome_proxy/webdriver/lite_page.py View 1 2 3 4 5 chunks +59 lines, -23 lines 0 comments Download
M tools/chrome_proxy/webdriver/lofi.py View 1 2 3 5 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
dougarnett
Resolved with buettner that we will retain the exp=ignore_preview_blacklist in order to be able to ...
3 years, 6 months ago (2017-06-15 19:32:57 UTC) #4
bustamante
On 2017/06/15 19:32:57, dougarnett wrote: > Resolved with buettner that we will retain the exp=ignore_preview_blacklist ...
3 years, 6 months ago (2017-06-15 19:50:28 UTC) #5
dougarnett
On 2017/06/15 19:50:28, bustamante wrote: > On 2017/06/15 19:32:57, dougarnett wrote: > > Resolved with ...
3 years, 6 months ago (2017-06-15 22:38:42 UTC) #6
dougarnett
Ping Megan - do you want to look at these integration test improvements?
3 years, 6 months ago (2017-06-19 15:57:28 UTC) #8
megjablon
lgtm
3 years, 6 months ago (2017-06-19 20:14:48 UTC) #9
dougarnett
Renamed two triggering tests (Slow/Fast) from testLitePage* to testPreview* to better match allowed server behavior. ...
3 years, 6 months ago (2017-06-19 22:30:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941103002/80001
3 years, 6 months ago (2017-06-20 16:47:49 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/b8ae3bdd6f625ef983b2615b74f240506dcbde8b
3 years, 6 months ago (2017-06-20 16:55:17 UTC) #20
bustamante
3 years, 6 months ago (2017-06-20 16:57:32 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698