Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2941013003: Introduce ComputeInlineBoxPositionForTextNode() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ComputeInlineBoxPositionForTextNode() This patch Introduces |ComputeInlineBoxPositionForTextNode()| split from |ComputeInlineBoxPositionTemplate()| to make it smaller for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2941013003 Cr-Commit-Position: refs/heads/master@{#479645} Committed: https://chromium.googlesource.com/chromium/src/+/9c3619e9e404908d6f67e4e7195bd03e5f0316d7

Patch Set 1 : 2017-06-15T15:39:24 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-15 07:06:03 UTC) #5
yoichio
lgtm
3 years, 6 months ago (2017-06-15 07:41:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941013003/1
3 years, 6 months ago (2017-06-15 07:43:41 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 08:57:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c3619e9e404908d6f67e4e7195b...

Powered by Google App Engine
This is Rietveld 408576698