Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: ios/web_view/test/chrome_web_view_test.mm

Issue 2940953003: Consolidated all CWVWebView test helpers inside web_view_test_util file. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web_view/test/chrome_web_view_test.h ('k') | ios/web_view/test/web_view_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/test/chrome_web_view_test.mm
diff --git a/ios/web_view/test/chrome_web_view_test.mm b/ios/web_view/test/chrome_web_view_test.mm
index 2a8b6cb420027a88027d59a857a4e69c3040a6a4..f51ad19a7eca8e13493f25cd29371a3a8ce94de3 100644
--- a/ios/web_view/test/chrome_web_view_test.mm
+++ b/ios/web_view/test/chrome_web_view_test.mm
@@ -133,18 +133,4 @@ GURL ChromeWebViewTest::GetUrlForPageWithTitleAndBody(const std::string& title,
return url;
}
-void ChromeWebViewTest::LoadUrl(CWVWebView* web_view, NSURL* url) {
- [web_view loadRequest:[NSURLRequest requestWithURL:url]];
-
- WaitForPageLoadCompletion(web_view);
-}
-
-void ChromeWebViewTest::WaitForPageLoadCompletion(CWVWebView* web_view) {
- BOOL success =
- testing::WaitUntilConditionOrTimeout(testing::kWaitForPageLoadTimeout, ^{
- return !web_view.isLoading;
- });
- ASSERT_TRUE(success);
-}
-
} // namespace ios_web_view
« no previous file with comments | « ios/web_view/test/chrome_web_view_test.h ('k') | ios/web_view/test/web_view_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698