Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2940913002: In sync passphrase dialog reset left bar button and title to saved values (Closed)

Created:
3 years, 6 months ago by pavely
Modified:
3 years, 6 months ago
Reviewers:
lpromero
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

In sync passphrase dialog reset left bar button and title to saved values They are currently reset to nil. R=lpromero@chromium.org BUG=731887 Review-Url: https://codereview.chromium.org/2940913002 Cr-Commit-Position: refs/heads/master@{#479642} Committed: https://chromium.googlesource.com/chromium/src/+/4873f6cb2f8c674cbf7529b69820cd58c2d4df1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
pavely
Louis, PTAL.
3 years, 6 months ago (2017-06-14 18:42:57 UTC) #3
lpromero
lgtm Thank you for the fix. This was introduced by a clang tool to migrate ...
3 years, 6 months ago (2017-06-15 08:32:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940913002/1
3 years, 6 months ago (2017-06-15 08:32:54 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 08:37:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4873f6cb2f8c674cbf7529b69820...

Powered by Google App Engine
This is Rietveld 408576698