Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2940883005: MD Settings: settings-subpage-search, add text ellipsis for placeholder text. (Closed)

Created:
3 years, 6 months ago by dpapad
Modified:
3 years, 6 months ago
Reviewers:
scottchen
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: settings-subpage-search, add text ellipsis for placeholder text. BUG=733095 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2940883005 Cr-Commit-Position: refs/heads/master@{#479456} Committed: https://chromium.googlesource.com/chromium/src/+/0a9fd735b58bf6fe1a7eb2b9d743dc65650afc02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_page/settings_subpage_search.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dpapad
Before/after screenshots at http://imgur.com/a/uRWZK.
3 years, 6 months ago (2017-06-14 17:07:29 UTC) #4
scottchen
On 2017/06/14 17:07:29, dpapad wrote: > Before/after screenshots at http://imgur.com/a/uRWZK. LGTM, but I did notice ...
3 years, 6 months ago (2017-06-14 17:50:14 UTC) #6
dpapad
On 2017/06/14 at 17:50:14, scottchen wrote: > On 2017/06/14 17:07:29, dpapad wrote: > > Before/after ...
3 years, 6 months ago (2017-06-14 17:52:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940883005/1
3 years, 6 months ago (2017-06-14 18:05:21 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 18:51:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a9fd735b58bf6fe1a7eb2b9d743...

Powered by Google App Engine
This is Rietveld 408576698