Move loading methods from WebFrame to WebLocalFrame.

Move loading methods from WebFrame to WebLocalFrame.

This CL moves 3 methods from WebFrame to WebLocalFrame:
- Reload
- ReloadWithOverrideURL
- LoadRequest

All callers except tests already call through WebLocalFrame.

No expected behavior change in the product code.

BUG=416660
Review-Url: https://codereview.chromium.org/2940863005
Cr-Commit-Position: refs/heads/master@{#480692}
Committed: https://chromium.googlesource.com/chromium/src/+/96c9582ab93d94dd07dfe3ff21133082a798728a

[Łukasz Anforowicz, 2017-06-15 22:25:54]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 22:26:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 01:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 01:06:09]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-06-16 23:36:46]

Description was changed from

==========
Move loading methods from WebFrame to WebLocalFrame.

All callers except tests already call through WebLocalFrame.

No expected behavior change.

BUG=416660
==========

to

==========
Move loading methods from WebFrame to WebLocalFrame.

All callers except tests already call through WebLocalFrame.

No expected behavior change in the product code.

BUG=416660
==========

[Łukasz Anforowicz, 2017-06-16 23:39:07]

Description was changed from

==========
Move loading methods from WebFrame to WebLocalFrame.

All callers except tests already call through WebLocalFrame.

No expected behavior change in the product code.

BUG=416660
==========

to

==========
Move loading methods from WebFrame to WebLocalFrame.

This CL moves 3 methods from WebFrame to WebLocalFrame:
- Reload
- ReloadWithOverrideURL
- LoadRequest

All callers except tests already call through WebLocalFrame.

No expected behavior change in the product code.

BUG=416660
==========

[Łukasz Anforowicz, 2017-06-16 23:39:57]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-06-16 23:39:57]

dcheng@, could you PTAL?

[dcheng, 2017-06-16 23:54:13]

LGTM.

Though I feel uncertain about the blink test runner change... maybe there's some
work we're missing there.

https://codereview.chromium.org/2940863005/diff/1/content/shell/renderer/layo...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/2940863005/diff/1/content/shell/renderer/layo...
content/shell/renderer/layout_test/blink_test_runner.cc:1030: if
(render_view()->GetWebView()->MainFrame()->IsWebLocalFrame()) {
Hmm... seems racy for OOPIFs then... about:blank commits synchronously here, so
that's fine, but in other renderers...

Maybe this is the best we can do for now.

[Łukasz Anforowicz, 2017-06-19 22:29:11]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 22:29:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-06-19 22:30:42]

https://codereview.chromium.org/2940863005/diff/1/content/shell/renderer/layo...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/2940863005/diff/1/content/shell/renderer/layo...
content/shell/renderer/layout_test/blink_test_runner.cc:1030: if
(render_view()->GetWebView()->MainFrame()->IsWebLocalFrame()) {
On 2017/06/16 23:54:13, dcheng wrote:
> Hmm... seems racy for OOPIFs then... about:blank commits synchronously here,
so
> that's fine, but in other renderers...
> 
> Maybe this is the best we can do for now.

I looked closer and it seems that the ShellViewMsg_Reset is only sent to the
current view (well, almost - before this CL the routing id was saved/bound
before sending the IPC;  after this CL this IPC will really always be send to
the current view).

These changes are in
content/shell/browser/layout_test/blink_test_controller.cc
content/shell/browser/layout_test/blink_test_controller.h
content/shell/renderer/layout_test/blink_test_runner.cc
(I've accidentally included a rebase in the most recent patchset...).

[Łukasz Anforowicz, 2017-06-19 22:32:38]

lukasza@chromium.org changed reviewers:
+ alexmos@chromium.org

[Łukasz Anforowicz, 2017-06-19 22:32:38]

alexmos@, could you PTAL at
    content/shell/browser/layout_test/blink_test_controller.cc
    content/shell/browser/layout_test/blink_test_controller.h
    content/shell/renderer/layout_test/blink_test_runner.cc
?

[commit-bot: I haz the power, 2017-06-19 22:33:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 22:33:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Łukasz Anforowicz, 2017-06-19 22:43:41]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 22:44:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alexmos, 2017-06-19 22:56:47]

content/ LGTM

[commit-bot: I haz the power, 2017-06-19 23:04:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 23:04:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Łukasz Anforowicz, 2017-06-19 23:19:46]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-19 23:19:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
alexmos@chromium.org
Link to the patchset: https://codereview.chromium.org/2940863005/#ps60001
(title: "Fixing build problems introduced by rebasing...")

[commit-bot: I haz the power, 2017-06-19 23:20:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 02:33:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497914386943830,
"parent_rev": "a5c894fde7c9ad57c70cb79c98e21c02aef8de07", "commit_rev":
"6708887a1bb7cb01f05e5e80acf9985d3e6ec66a"}

[commit-bot: I haz the power, 2017-06-20 02:34:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497914386943830,
"parent_rev": "c786706f53dcd6e2562832d7a857ca6ffe32f4bb", "commit_rev":
"96c9582ab93d94dd07dfe3ff21133082a798728a"}

[commit-bot: I haz the power, 2017-06-20 02:34:13]

Description was changed from

==========
Move loading methods from WebFrame to WebLocalFrame.

This CL moves 3 methods from WebFrame to WebLocalFrame:
- Reload
- ReloadWithOverrideURL
- LoadRequest

All callers except tests already call through WebLocalFrame.

No expected behavior change in the product code.

BUG=416660
==========

to

==========
Move loading methods from WebFrame to WebLocalFrame.

This CL moves 3 methods from WebFrame to WebLocalFrame:
- Reload
- ReloadWithOverrideURL
- LoadRequest

All callers except tests already call through WebLocalFrame.

No expected behavior change in the product code.

BUG=416660

Review-Url: https://codereview.chromium.org/2940863005
Cr-Commit-Position: refs/heads/master@{#480692}
Committed:
https://chromium.googlesource.com/chromium/src/+/96c9582ab93d94dd07dfe3ff2113...
==========

[commit-bot: I haz the power, 2017-06-20 02:34:14]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/96c9582ab93d94dd07dfe3ff2113...

[Łukasz Anforowicz, 2017-06-22 16:45:46]

Just wanted to add a comment pointing out a part of this CL that has introduced
a test-only crash / regression.  I am trying to fix this in
https://crrev.com/2946103003.

https://codereview.chromium.org/2940863005/diff/60001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2940863005/diff/60001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:698:
main_window_->web_contents()->GetRenderViewHost()->GetRoutingID()));
It turns out that |main_window_| can be null here - see
https://codereview.chromium.org/2946103003.