[ios clean] Use dispatcher for showing TabStrip

ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm

Index: ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm
diff --git a/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm b/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm
index 6ab9c7cdcbefda99f17b04bb8f4b5a141418b196..7afb4b5784e2a5eb329a67ec3a147060a99ee848 100644
--- a/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm
+++ b/ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm
@@ -6,9 +6,9 @@
 
 #import "base/mac/foundation_util.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
-#import "ios/clean/chrome/browser/ui/actions/tab_strip_actions.h"
 #import "ios/clean/chrome/browser/ui/commands/navigation_commands.h"
 #import "ios/clean/chrome/browser/ui/commands/tab_grid_commands.h"
+#import "ios/clean/chrome/browser/ui/commands/tab_strip_commands.h"
 #import "ios/clean/chrome/browser/ui/commands/tools_menu_commands.h"
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.h"
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_component_options.h"
@@ -159,7 +159,7 @@
   [buttonConstraints
       addObject:[self.tabSwitchStripButton.widthAnchor
                     constraintEqualToConstant:kToolbarButtonWidth]];
-  [self.tabSwitchStripButton addTarget:nil
+  [self.tabSwitchStripButton addTarget:self
                                 action:@selector(showTabStrip:)
                       forControlEvents:UIControlEventTouchUpInside];
   [self.tabSwitchStripButton
@@ -375,7 +375,7 @@
                   fromView:self.toolsMenuButton];
 }
 
-#pragma mark - Private Methods
+#pragma mark - Commands
 
 - (void)showToolsMenu:(id)sender {
   [self.dispatcher showToolsMenu];
@@ -405,6 +405,10 @@
   [self.dispatcher reloadPage];
 }
 
+- (void)showTabStrip:(id)sender {

[marq (ping after 24h), 2017/06/15 07:35:35]

No change, but this block of boilerplate makes me wonder if there's any reason
to route the dispatcher calls through local methods at all. Should we just set
the dispatcher as an action target when we can?

[sczs, 2017/06/15 19:56:17]

I agree, might was well change it on this CL. Since the button setup is done on
init (the mediator needs to access the buttons before viewDidLoad) I've added an
extra method to init the VC with a dispatcher.

I'm still exposing the dispatcher for consistency and I guess it could be needed
for swipe to change tabs?

+  [self.dispatcher showTabStrip];
+}
+
 - (void)showTabGrid:(id)sender {
   [self.dispatcher showTabGrid];
 }