[ios clean] Use dispatcher for showing TabStrip

ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h"
 
 #import "base/mac/foundation_util.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
-#import "ios/clean/chrome/browser/ui/actions/tab_strip_actions.h"
 #import "ios/clean/chrome/browser/ui/commands/navigation_commands.h"
 #import "ios/clean/chrome/browser/ui/commands/tab_grid_commands.h"
+#import "ios/clean/chrome/browser/ui/commands/tab_strip_commands.h"
 #import "ios/clean/chrome/browser/ui/commands/tools_menu_commands.h"
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.h"
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_component_options.h"
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_constants.h"
 #import "ios/third_party/material_components_ios/src/components/ProgressView/src/MaterialProgressView.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
@@ skipping 130 matching lines @@
                forControlEvents:UIControlEventTouchUpInside];
 
   // Tab switcher Strip button.
   self.tabSwitchStripButton = [ToolbarButton tabSwitcherStripToolbarButton];
   self.tabSwitchStripButton.visibilityMask =
       ToolbarComponentVisibilityCompactWidth |
       ToolbarComponentVisibilityRegularWidth;
   [buttonConstraints
       addObject:[self.tabSwitchStripButton.widthAnchor
                     constraintEqualToConstant:kToolbarButtonWidth]];
-  [self.tabSwitchStripButton addTarget:nil
+  [self.tabSwitchStripButton addTarget:self
                                 action:@selector(showTabStrip:)
                       forControlEvents:UIControlEventTouchUpInside];
   [self.tabSwitchStripButton
       setTitleColor:UIColorFromRGB(kToolbarButtonTitleNormalColor)
            forState:UIControlStateNormal];
   [self.tabSwitchStripButton
       setTitleColor:UIColorFromRGB(kToolbarButtonTitleHighlightedColor)
            forState:UIControlStateHighlighted];
 
   // Tab switcher Grid button.
@@ skipping 195 matching lines @@
   [self.tabSwitchStripButton setAccessibilityValue:tabStripButtonValue];
 }
 
 #pragma mark - ZoomTransitionDelegate
 
 - (CGRect)rectForZoomWithKey:(NSObject*)key inView:(UIView*)view {
   return [view convertRect:self.toolsMenuButton.bounds
                   fromView:self.toolsMenuButton];
 }
 
-#pragma mark - Private Methods
+#pragma mark - Commands
 
 - (void)showToolsMenu:(id)sender {
   [self.dispatcher showToolsMenu];
 }
 
 - (void)closeToolsMenu:(id)sender {
   [self.dispatcher closeToolsMenu];
 }
 
 - (void)showShareMenu:(id)sender {
   [self.dispatcher showShareMenu];
 }
 
 - (void)goBack:(id)sender {
   [self.dispatcher goBack];
 }
 
 - (void)goForward:(id)sender {
   [self.dispatcher goForward];
 }
 
 - (void)stop:(id)sender {
   [self.dispatcher stopLoadingPage];
 }
 
 - (void)reload:(id)sender {
   [self.dispatcher reloadPage];
 }
 
+- (void)showTabStrip:(id)sender {

[marq (ping after 24h), 2017/06/15 07:35:35]

No change, but this block of boilerplate makes me wonder if there's any reason
to route the dispatcher calls through local methods at all. Should we just set
the dispatcher as an action target when we can?

[sczs, 2017/06/15 19:56:17]

I agree, might was well change it on this CL. Since the button setup is done on
init (the mediator needs to access the buttons before viewDidLoad) I've added an
extra method to init the VC with a dispatcher.

I'm still exposing the dispatcher for consistency and I guess it could be needed
for swipe to change tabs?

+  [self.dispatcher showTabStrip];
+}
+
 - (void)showTabGrid:(id)sender {
   [self.dispatcher showTabGrid];
 }
 
 #pragma mark - Helper Methods
 
 // Updates all Buttons visibility to match any recent WebState change.
 - (void)updateAllButtonsVisibility {
   for (UIView* view in self.stackView.arrangedSubviews) {
     if ([view isKindOfClass:[ToolbarButton class]]) {
       ToolbarButton* button = base::mac::ObjCCastStrict<ToolbarButton>(view);
       [button setHiddenForCurrentStateAndSizeClass];
     }
   }
 }
 
 // Sets the priority for an array of constraints and activates them.
 - (void)activateConstraints:(NSArray*)constraintsArray
                withPriority:(UILayoutPriority)priority {
   for (NSLayoutConstraint* constraint in constraintsArray) {
     constraint.priority = priority;
   }
   [NSLayoutConstraint activateConstraints:constraintsArray];
 }
 
 @end