Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2940823002: Fix metric for new CBD dialog (Closed)

Created:
3 years, 6 months ago by dullweber
Modified:
3 years, 6 months ago
Reviewers:
Theresa
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Fix metric for new CBD dialog A bug is fixed where "ClearBrowsingData_DialogCreated" was recorded twice because the new CBD dialog creates two instances of ClearBrowsingDataPreferences. (cherry picked from http://crrev.com/2927063002 with everything but this bugfix reverted) BUG=731120 TBR=twellington@chromium.org Review-Url: https://codereview.chromium.org/2927063002 Cr-Original-Commit-Position: refs/heads/master@{#478602} Review-Url: https://codereview.chromium.org/2940823002 . Cr-Commit-Position: refs/branch-heads/3112@{#341} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/69601320533e89949caa6cb3a05b63ff4804da59

Patch Set 1 #

Patch Set 2 : revert everything except bugfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (4 generated)
dullweber
3 years, 6 months ago (2017-06-14 08:24:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
69601320533e89949caa6cb3a05b63ff4804da59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698