Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2940763002: Move some functions from net/cert/x509_util_nss.cc into x509_certificate_nss.cc (Closed)

Created:
3 years, 6 months ago by mattm
Modified:
3 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some functions from net/cert/x509_util_nss.cc into x509_certificate_nss.cc These functions are only used by x509_certificate_nss.cc, and will be unnecessary when switching to x509_certificate_bytes. BUG=671420 Review-Url: https://codereview.chromium.org/2940763002 Cr-Commit-Position: refs/heads/master@{#479273} Committed: https://chromium.googlesource.com/chromium/src/+/919485c7f33741de04be2a3ffddccbf50f349a20

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -382 lines) Patch
M net/cert/x509_certificate_nss.cc View 6 chunks +297 lines, -15 lines 0 comments Download
M net/cert/x509_util_nss.h View 1 2 chunks +0 lines, -67 lines 0 comments Download
M net/cert/x509_util_nss.cc View 1 4 chunks +2 lines, -300 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
mattm
3 years, 6 months ago (2017-06-14 02:06:48 UTC) #4
eroman
lgtm
3 years, 6 months ago (2017-06-14 02:14:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940763002/20001
3 years, 6 months ago (2017-06-14 03:15:57 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 03:40:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/919485c7f33741de04be2a3ffddc...

Powered by Google App Engine
This is Rietveld 408576698