git cl format chrome/browser/extensions/api/file_system/file_system_api.cc

git cl format chrome/browser/extensions/api/file_system/file_system_api.cc

Format this file to reduce the diff of a CL that will split it in two.

BUG=729713
R=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2940713002
Cr-Commit-Position: refs/heads/master@{#479184}
Committed: https://chromium.googlesource.com/chromium/src/+/dfa7181f951ed4f6dfedcdd530137a94d6a58008

[michaelpg, 2017-06-13 20:29:29]

Description was changed from

==========
git cl format chrome/browser/extensions/api/file_system/file_system_api.cc

Format this file to reduce the diff of a CL that will split it in two.

BUG=729713
R=benwells@chromium.org
==========

to

==========
git cl format chrome/browser/extensions/api/file_system/file_system_api.cc

Format this file to reduce the diff of a CL that will split it in two.

BUG=729713
R=rdevlin.cronin@chromium.org
==========

[michaelpg, 2017-06-13 20:29:29]

michaelpg@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org
- benwells@chromium.org

[michaelpg, 2017-06-13 20:29:41]

A freebie for you.

[Devlin, 2017-06-13 20:32:45]

lgtm!

https://codereview.chromium.org/2940713002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/file_system_api.cc (right):

https://codereview.chromium.org/2940713002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.cc:83: "Invalid
calling page. This function can't "
nit: git cl format can't fix the wrapping.  Mind doing it?

[michaelpg, 2017-06-13 20:39:46]

https://codereview.chromium.org/2940713002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/file_system_api.cc (right):

https://codereview.chromium.org/2940713002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.cc:83: "Invalid
calling page. This function can't "
On 2017/06/13 20:32:45, Devlin wrote:
> nit: git cl format can't fix the wrapping.  Mind doing it?

It won't fit on one line. Wrapping before "page" might be the strict style
guideline, but how about wrapping at the sentence so grepping an error message
might be slightly less likely to fail?

[Devlin, 2017-06-13 20:42:16]

https://codereview.chromium.org/2940713002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/file_system/file_system_api.cc (right):

https://codereview.chromium.org/2940713002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/file_system/file_system_api.cc:83: "Invalid
calling page. This function can't "
On 2017/06/13 20:39:46, michaelpg wrote:
> On 2017/06/13 20:32:45, Devlin wrote:
> > nit: git cl format can't fix the wrapping.  Mind doing it?
> 
> It won't fit on one line. Wrapping before "page" might be the strict style
> guideline, but how about wrapping at the sentence so grepping an error message
> might be slightly less likely to fail?

sure.  I'm fine with either logical or stylistic. :)

[michaelpg, 2017-06-13 21:11:01]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2017-06-13 21:11:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2940713002/#ps20001
(title: "wrapping")

[commit-bot: I haz the power, 2017-06-13 21:11:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 22:39:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497388261371690,
"parent_rev": "3e46aa6ced2554cd07a7cc9aad1ec98b384dff07", "commit_rev":
"dfa7181f951ed4f6dfedcdd530137a94d6a58008"}

[commit-bot: I haz the power, 2017-06-13 22:39:26]

Description was changed from

==========
git cl format chrome/browser/extensions/api/file_system/file_system_api.cc

Format this file to reduce the diff of a CL that will split it in two.

BUG=729713
R=rdevlin.cronin@chromium.org
==========

to

==========
git cl format chrome/browser/extensions/api/file_system/file_system_api.cc

Format this file to reduce the diff of a CL that will split it in two.

BUG=729713
R=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2940713002
Cr-Commit-Position: refs/heads/master@{#479184}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfa7181f951ed4f6dfedcdd53013...
==========

[commit-bot: I haz the power, 2017-06-13 22:39:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dfa7181f951ed4f6dfedcdd53013...