pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart - Issue 2940703002: Fix top level type inference for binary operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

Issue 2940703002: Fix top level type inference for binary operators. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

index 5744eaf77906cc1c61a773352abec151c4ec1727..85dcbaa81ae60778bcaf34d6aa582dca09c3abab 100644

--- a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

@@ -1273,6 +1273,9 @@ class KernelMethodInvocation extends MethodInvocation

// The inference dependencies are the inference dependencies of the

// receiver.

collector.collectDependencies(receiver);

+ if (name == '+' || name == '-' || name == '*' || name == '%') {

scheglov 2017/06/13 19:46:51 Is it unsafe to use identical() here?

Paul Berry 2017/06/13 20:06:39 Oops, I should have thought of that. identical()

+ collector.collectDependencies(arguments.positional[0]);

+ }

}

@override