pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart - Issue 2940703002: Fix top level type inference for binary operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

Issue 2940703002: Fix top level type inference for binary operators. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart b/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

index 344851102078e9336c4436672b256e80337c4714..f51ba659ba6d2a52f6cb2b01ac588e897e9452d4 100644

--- a/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

+++ b/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

@@ -549,7 +549,7 @@ abstract class TypeInferrerImpl extends TypeInferrer {

}

// TODO(paulberry): if we are doing top level inference and type arguments

// were omitted, report an error.

- if (!isTopLevel) {

+ if (!isTopLevel || isOverloadedArithmeticOperator) {

int i = 0;

_forEachArgument(arguments, (name, expression) {

DartType formalType = name != null