Fix top level type inference for binary operators.

Fix top level type inference for binary operators.

Multiple changes were required:

- The analyzer's mock SDK had an incorrect return type for
  `num.operator/`.

- We weren't considering the RHS of the binary operators `+`, `-`,
  `*`, and `%` to be an inference dependency (we need to, since the
  special overload rules for int depend on the type of the RHS).

- We weren't executing the overload logic when doing top level type
  inference.

- The logic for deciding what operators are overloaded was incorrect.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/a1ecb46a4c657ff5bc59b5fce98004ca21246135

[Paul Berry, 2017-06-13 19:39:04]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-06-13 19:46:51]

LGTM

https://codereview.chromium.org/2940703002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):

https://codereview.chromium.org/2940703002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:1276: if (name == '+'
|| name == '-' || name == '*' || name == '%') {
Is it unsafe to use identical() here?

[Paul Berry, 2017-06-13 20:06:39]

https://codereview.chromium.org/2940703002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):

https://codereview.chromium.org/2940703002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:1276: if (name == '+'
|| name == '-' || name == '*' || name == '%') {
On 2017/06/13 19:46:51, scheglov wrote:
> Is it unsafe to use identical() here?

Oops, I should have thought of that.  identical() is better.  Fixed.

[Paul Berry, 2017-06-13 20:07:05]

Description was changed from

==========
Fix top level type inference for binary operators.

Multiple changes were required:

- The analyzer's mock SDK had an incorrect return type for
  `num.operator/`.

- We weren't considering the RHS of the binary operators `+`, `-`,
  `*`, and `%` to be an inference dependency (we need to, since the
  special overload rules for int depend on the type of the RHS).

- We weren't executing the overload logic when doing top level type
  inference.

- The logic for deciding what operators are overloaded was incorrect.
==========

to

==========
Fix top level type inference for binary operators.

Multiple changes were required:

- The analyzer's mock SDK had an incorrect return type for
  `num.operator/`.

- We weren't considering the RHS of the binary operators `+`, `-`,
  `*`, and `%` to be an inference dependency (we need to, since the
  special overload rules for int depend on the type of the RHS).

- We weren't executing the overload logic when doing top level type
  inference.

- The logic for deciding what operators are overloaded was incorrect.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a1ecb46a4c657ff5bc59b5fce98004ca21246135
==========

[Paul Berry, 2017-06-13 20:07:06]

Committed patchset #1 (id:1) manually as
a1ecb46a4c657ff5bc59b5fce98004ca21246135 (presubmit successful).