Issue 2940653002: Trim the String, not the Future.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2940653002: Trim the String, not the Future. (Closed)

Created:
3 years, 6 months ago by ahe

Modified:
3 years, 6 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/testing/lib/src/analyze.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

ahe

I don't understand why I didn't catch this when testing locally.

3 years, 6 months ago (2017-06-13 14:10:28 UTC) #2

ahe

3 years, 6 months ago (2017-06-13 14:16:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dcf133589a91c2897b8ba1dbeea8afe8f239dbf9 (presubmit successful).