pkg/testing/lib/src/analyze.dart - Issue 2940653002: Trim the String, not the Future.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/testing/lib/src/analyze.dart

Issue 2940653002: Trim the String, not the Future. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/testing/lib/src/analyze.dart

diff --git a/pkg/testing/lib/src/analyze.dart b/pkg/testing/lib/src/analyze.dart

index fc32fd4ec25d2ab189118c0791331f9bf39a061d..296a023fb58389f25878366eed2a12bb1a550e31 100644

--- a/pkg/testing/lib/src/analyze.dart

+++ b/pkg/testing/lib/src/analyze.dart

@@ -159,7 +159,7 @@ Future<Null> analyzeUris(

String topLevel;

try {

topLevel = new Uri.directory(

- await git("rev-parse", <String>["--show-toplevel"]).trimRight())

+ (await git("rev-parse", <String>["--show-toplevel"])).trimRight())

.toFilePath(windows: false);

} catch (e) {

topLevel = Uri.base.toFilePath(windows: false);

« no previous file with comments | « no previous file | no next file » | no next file with comments »