Run BlobURLRequestJobTest tests with BlobURLRequestJob and BlobURLLoader.

Run BlobURLRequestJobTest tests with BlobURLRequestJob and BlobURLLoader.

BUG=715677
Review-Url: https://codereview.chromium.org/2940603003
Cr-Commit-Position: refs/heads/master@{#479212}
Committed: https://chromium.googlesource.com/chromium/src/+/fdf52023f531d3bb73459e021a243d5aae076de7

[jam, 2017-06-13 17:15:33]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 17:15:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-06-13 17:29:13]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-06-13 17:29:15]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-06-13 17:29:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 18:11:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 18:11:33]

Dry run: This issue passed the CQ dry run.

[jam, 2017-06-13 18:28:18]

jam@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2017-06-13 19:57:09]

LGTM, modulo comment.

https://codereview.chromium.org/2940603003/diff/20001/content/browser/blob_st...
File content/browser/blob_storage/blob_url_unittest.cc (right):

https://codereview.chromium.org/2940603003/diff/20001/content/browser/blob_st...
content/browser/blob_storage/blob_url_unittest.cc:133: class
BlobURLRequestJobTest : public testing::TestWithParam<bool> {
Should add a comment on what the param means.  I'd suggest both one here and
where you check it in TestRequest.  Alternatively, could use an enum class
instead of a bool.

[jam, 2017-06-13 23:17:20]

https://codereview.chromium.org/2940603003/diff/20001/content/browser/blob_st...
File content/browser/blob_storage/blob_url_unittest.cc (right):

https://codereview.chromium.org/2940603003/diff/20001/content/browser/blob_st...
content/browser/blob_storage/blob_url_unittest.cc:133: class
BlobURLRequestJobTest : public testing::TestWithParam<bool> {
On 2017/06/13 19:57:09, mmenke wrote:
> Should add a comment on what the param means.  I'd suggest both one here and
> where you check it in TestRequest.  Alternatively, could use an enum class
> instead of a bool.

Added one here. I didn't want to add one where it's used because it's
documenting what the code is doing, and would be redundant from here.

[jam, 2017-06-13 23:22:24]

The CQ bit was checked by jam@chromium.org

[jam, 2017-06-13 23:22:24]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2940603003/#ps40001
(title: "review comment")

[commit-bot: I haz the power, 2017-06-13 23:22:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 23:56:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497396144364040,
"parent_rev": "2437f9950a67ed3838443fb8f23b7d070f69f6a8", "commit_rev":
"fdf52023f531d3bb73459e021a243d5aae076de7"}

[commit-bot: I haz the power, 2017-06-13 23:56:50]

Description was changed from

==========
Run BlobURLRequestJobTest tests with BlobURLRequestJob and BlobURLLoader.

BUG=715677
==========

to

==========
Run BlobURLRequestJobTest tests with BlobURLRequestJob and BlobURLLoader.

BUG=715677

Review-Url: https://codereview.chromium.org/2940603003
Cr-Commit-Position: refs/heads/master@{#479212}
Committed:
https://chromium.googlesource.com/chromium/src/+/fdf52023f531d3bb73459e021a24...
==========

[commit-bot: I haz the power, 2017-06-13 23:56:52]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fdf52023f531d3bb73459e021a24...