Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 2940583002: Move drag related functionality out of LocalFrame (Closed)

Created:
3 years, 6 months ago by tanvir
Modified:
3 years, 5 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move drag related functionality out of LocalFrame Class DraggedNodeImageBuilder, and functions DeviceSpaceBounds, CreateDragImageForFrame, NodeImage and DragImageForSelection are currently implemented in LocalFrame class, but these functions are irrelevant to LocalFrame, so these functions are moved to appropriate drag related files. BUG=727981

Patch Set 1 #

Patch Set 2 : updatedPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -372 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.h View 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 4 chunks +149 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp View 1 8 chunks +21 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 5 chunks +0 lines, -179 lines 0 comments Download
D third_party/WebKit/Source/core/frame/LocalFrameTest.cpp View 1 chunk +0 lines, -146 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 3 chunks +24 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/page/DragControllerTest.cpp View 1 chunk +70 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (6 generated)
tanvir
Hi Xiaochengh, PTAL!!!. I have created a new patch for this( reference patch is https://codereview.chromium.org/2916043002/ ...
3 years, 6 months ago (2017-06-13 08:22:11 UTC) #3
Xiaocheng
3 years, 6 months ago (2017-06-13 17:54:17 UTC) #8
Could you split it into two patches?

Patch 1: Modify the functions in-place (in LocalFrame.cpp), without moving them
to a different file. The reason is that when moving a function from LocalFrame
to, say, DragController, its parameters must be changed. Changing the function
in-place make it easier to compare the code change.

Patch 2: Move the modified functions to other files. This patch is pure code
moving without any change (other than fixing includes and/or forward
declarations).

Thanks!

Powered by Google App Engine
This is Rietveld 408576698