Fix SW tests with servicification

Fix SW tests with servicification

Instead of disabling SW interception entirely just
make IsControlledByServiceWorker false for subresources for now
(to avoid undesirable DCHECKs).

BUG=715640
TEST=ServiceWorkerDisableWebSecurityTest.RegisterNoCrash,ServiceWorkerDisableWebSecurityTest.GetRegistrationNoCrash with --enable-network-service

Review-Url: https://codereview.chromium.org/2940563002
Cr-Commit-Position: refs/heads/master@{#478958}
Committed: https://chromium.googlesource.com/chromium/src/+/9061a92f5c2d505e792cf02ec95dcac8946298df

[kinuko, 2017-06-13 05:38:00]

Description was changed from

==========
Fix SW tests with servicification

Instead of disabling SW interception entirely just
make IsControlledByServiceWorker false for subresources for now
(to avoid undesirable DCHECKs).

BUG=715640
TEST=ServiceWorkerDisableWebSecurityTest.RegisterNoCrash,ServiceWorkerDisableWebSecurityTest.GetRegistrationNoCrash
with --enable-network-service
==========

to

==========
Fix SW tests with servicification

Instead of disabling SW interception entirely just
make IsControlledByServiceWorker false for subresources for now
(to avoid undesirable DCHECKs).

BUG=715640
TEST=ServiceWorkerDisableWebSecurityTest.RegisterNoCrash,ServiceWorkerDisableWebSecurityTest.GetRegistrationNoCrash
with --enable-network-service
==========

[kinuko, 2017-06-13 05:38:00]

kinuko@chromium.org changed reviewers:
+ falken@chromium.org

[kinuko, 2017-06-13 05:38:07]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 05:38:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-06-13 05:38:30]

PTL (manually ran tests)

[falken, 2017-06-13 05:48:47]

https://codereview.chromium.org/2940563002/diff/1/content/child/service_worke...
File content/child/service_worker/service_worker_network_provider.cc (right):

https://codereview.chromium.org/2940563002/diff/1/content/child/service_worke...
content/child/service_worker/service_worker_network_provider.cc:72:
!provider_->IsControlledByServiceWorker() &&
Seems likely this should use IsControlledByServiceWorker() instead?

https://codereview.chromium.org/2940563002/diff/1/content/child/service_worke...
content/child/service_worker/service_worker_network_provider.cc:236: bool
ServiceWorkerNetworkProvider::IsControlledByServiceWorker() const {
Would it be safer to put the return false here instead of above to cover the
callsites that come here directly?

[kinuko, 2017-06-13 06:45:55]

Thanks!

https://codereview.chromium.org/2940563002/diff/1/content/child/service_worke...
File content/child/service_worker/service_worker_network_provider.cc (right):

https://codereview.chromium.org/2940563002/diff/1/content/child/service_worke...
content/child/service_worker/service_worker_network_provider.cc:72:
!provider_->IsControlledByServiceWorker() &&
On 2017/06/13 05:48:47, falken wrote:
> Seems likely this should use IsControlledByServiceWorker() instead?

Changed the 'IsServicificationEnabled()' code in the provider_ instead

https://codereview.chromium.org/2940563002/diff/1/content/child/service_worke...
content/child/service_worker/service_worker_network_provider.cc:236: bool
ServiceWorkerNetworkProvider::IsControlledByServiceWorker() const {
On 2017/06/13 05:48:47, falken wrote:
> Would it be safer to put the return false here instead of above to cover the
> callsites that come here directly?

Done.

[falken, 2017-06-13 06:47:38]

lgtm

[kinuko, 2017-06-13 06:49:02]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-06-13 06:49:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 10:31:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497336542239360,
"parent_rev": "22c0bf14345003e73ba13be78089d31f3e00bd9f", "commit_rev":
"9061a92f5c2d505e792cf02ec95dcac8946298df"}

[commit-bot: I haz the power, 2017-06-13 10:31:35]

Description was changed from

==========
Fix SW tests with servicification

Instead of disabling SW interception entirely just
make IsControlledByServiceWorker false for subresources for now
(to avoid undesirable DCHECKs).

BUG=715640
TEST=ServiceWorkerDisableWebSecurityTest.RegisterNoCrash,ServiceWorkerDisableWebSecurityTest.GetRegistrationNoCrash
with --enable-network-service
==========

to

==========
Fix SW tests with servicification

Instead of disabling SW interception entirely just
make IsControlledByServiceWorker false for subresources for now
(to avoid undesirable DCHECKs).

BUG=715640
TEST=ServiceWorkerDisableWebSecurityTest.RegisterNoCrash,ServiceWorkerDisableWebSecurityTest.GetRegistrationNoCrash
with --enable-network-service

Review-Url: https://codereview.chromium.org/2940563002
Cr-Commit-Position: refs/heads/master@{#478958}
Committed:
https://chromium.googlesource.com/chromium/src/+/9061a92f5c2d505e792cf02ec95d...
==========

[commit-bot: I haz the power, 2017-06-13 10:31:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9061a92f5c2d505e792cf02ec95d...