Move all gcm activity types out of GCMStatsRecorder

Move all gcm activity types out of GCMStatsRecorder

This is needed to remove dependency on GCMStatsRecorder from GCMClient.

BUG=356716
TEST=existing tests
TBR=arv@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272675

[juyik, 2014-05-23 22:35:41]

lgtm

https://codereview.chromium.org/294053017/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/gcm_driver.cc (right):

https://codereview.chromium.org/294053017/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/gcm_driver.cc:12: #include "base/files/file_path.h"
Is this needed for this patch?

[jianli, 2014-05-23 22:37:55]

https://codereview.chromium.org/294053017/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/gcm_driver.cc (right):

https://codereview.chromium.org/294053017/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/gcm_driver.cc:12: #include "base/files/file_path.h"
On 2014/05/23 22:35:41, juyik wrote:
> Is this needed for this patch?

Yes. Now we need this because gcm_client.h does not include gcm_stats_recorder.h
which includes file_path.h indirectly.

[Nicolas Zea, 2014-05-24 00:01:28]

LGTM with a nit

Also, what is the plan for GCMStatsRecorder? Will it live in components/? It
seems like it might still be useful even with an Android driver/client to record
stats, although perhaps it would have a different implementation.

https://codereview.chromium.org/294053017/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/gcm_driver.cc (right):

https://codereview.chromium.org/294053017/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/gcm_driver.cc:12: #include "base/files/file_path.h"
On 2014/05/23 22:37:55, jianli wrote:
> On 2014/05/23 22:35:41, juyik wrote:
> > Is this needed for this patch?
> 
> Yes. Now we need this because gcm_client.h does not include
gcm_stats_recorder.h
> which includes file_path.h indirectly.

FilePath can be forward declared

[jianli, 2014-05-24 00:10:50]

For now, we only intend to move GCMActivity to components/gcm_driver. We
probably need to do some clean up to GCMStatsRecorder if we want to use it for
Android.

https://codereview.chromium.org/294053017/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/gcm_driver.cc (right):

https://codereview.chromium.org/294053017/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/gcm_driver.cc:12: #include "base/files/file_path.h"
On 2014/05/24 00:01:29, Nicolas Zea wrote:
> On 2014/05/23 22:37:55, jianli wrote:
> > On 2014/05/23 22:35:41, juyik wrote:
> > > Is this needed for this patch?
> > 
> > Yes. Now we need this because gcm_client.h does not include
> gcm_stats_recorder.h
> > which includes file_path.h indirectly.
> 
> FilePath can be forward declared

It is forward declared in gcm_client.h and we need it in this place because
otherwise we will get a compiling error as:

d:\src\chromium\src\base\bind_internal.h(2780) : error C2079:
'base::internal::BindState<base::internal::RunnableAdapter<T>,void
(gcm::GCMDriver::IOWorker *,A1,A2,A3,A4,A5,A6),void
(base::internal::UnretainedWrapper<gcm::GCMDriver::IOWorker>,base::internal::PassedWrapper<scoped_ptr<gcm::GCMClientFactory,base::DefaultDeleter<gcm::GCMClientFactory>>>,gcm::GCMClient::ChromeBuildInfo,base::FilePath,std::vector<std::string,std::allocator<_Ty>>,scoped_refptr<net::URLRequestContextGetter>,scoped_refptr<base::SequencedTaskRunner>)>::p4_'
uses undefined class 'base::FilePath'

[jianli, 2014-05-24 00:14:08]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-05-24 00:16:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/294053017/1

[jianli, 2014-05-24 00:30:20]

The CQ bit was unchecked by jianli@chromium.org

[jianli, 2014-05-24 00:30:26]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-05-24 00:31:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/294053017/1

[commit-bot: I haz the power, 2014-05-24 01:35:04]

Change committed as 272675