Move all gcm activity types out of GCMStatsRecorder

chrome/browser/services/gcm/gcm_driver.cc

Index: chrome/browser/services/gcm/gcm_driver.cc
diff --git a/chrome/browser/services/gcm/gcm_driver.cc b/chrome/browser/services/gcm/gcm_driver.cc
index 50ca9dc2926d65e87f5ba4a6e72459b902cdb5e3..357804214ce32cc7f7b9a1187b88824306f93777 100644
--- a/chrome/browser/services/gcm/gcm_driver.cc
+++ b/chrome/browser/services/gcm/gcm_driver.cc
@@ -9,6 +9,7 @@
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
+#include "base/files/file_path.h"

[juyik, 2014/05/23 22:35:41]

Is this needed for this patch?

[jianli, 2014/05/23 22:37:55]

Yes. Now we need this because gcm_client.h does not include gcm_stats_recorder.h
which includes file_path.h indirectly.

[Nicolas Zea, 2014/05/24 00:01:29]

FilePath can be forward declared

[jianli, 2014/05/24 00:10:50]

It is forward declared in gcm_client.h and we need it in this place because
otherwise we will get a compiling error as:

d:\src\chromium\src\base\bind_internal.h(2780) : error C2079:
'base::internal::BindState<base::internal::RunnableAdapter<T>,void
(gcm::GCMDriver::IOWorker *,A1,A2,A3,A4,A5,A6),void
(base::internal::UnretainedWrapper<gcm::GCMDriver::IOWorker>,base::internal::PassedWrapper<scoped_ptr<gcm::GCMClientFactory,base::DefaultDeleter<gcm::GCMClientFactory>>>,gcm::GCMClient::ChromeBuildInfo,base::FilePath,std::vector<std::string,std::allocator<_Ty>>,scoped_refptr<net::URLRequestContextGetter>,scoped_refptr<base::SequencedTaskRunner>)>::p4_'
uses undefined class 'base::FilePath'

 #include "base/location.h"
 #include "base/logging.h"
 #include "base/sequenced_task_runner.h"