Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2940483002: Autofill keyboard accessory: Fix repeated animations/accessibility announcements (Closed)

Created:
3 years, 6 months ago by Jared Saul
Modified:
3 years, 6 months ago
Reviewers:
sebsg
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, agrieve+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill keyboard accessory: Fix repeated animations/accessibility announcements BUG=732002, 729201 Review-Url: https://codereview.chromium.org/2940483002 Cr-Commit-Position: refs/heads/master@{#479011} Committed: https://chromium.googlesource.com/chromium/src/+/dad51faf7fb29c964bf46baee87bf5193a9e22f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M components/autofill/android/java/src/org/chromium/components/autofill/AutofillKeyboardAccessory.java View 6 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jared Saul
Hi Sébastien, PTAL; just some minor fixes for the keyboard accessory. Thanks!
3 years, 6 months ago (2017-06-12 21:47:44 UTC) #2
sebsg
lgtm
3 years, 6 months ago (2017-06-13 13:38:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940483002/1
3 years, 6 months ago (2017-06-13 13:38:24 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 14:29:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dad51faf7fb29c964bf46baee87b...

Powered by Google App Engine
This is Rietveld 408576698