[Offline Prefetch] Use proto2 syntax for offline prefetch proto

[Offline Prefetch] Use proto2 syntax for offline prefetch proto

Switching back to proto2 greatly reduced the size. Also moving
the proto definitions in timestamp.proto to where are referenced also saved a bunch. Note that moving other proto files did not save much.

BUG=733783
Review-Url: https://codereview.chromium.org/2940393002
Cr-Commit-Position: refs/heads/master@{#480230}
Committed: https://chromium.googlesource.com/chromium/src/+/08ca13d0991463f5646fb88a19460ea2b2778d14

[jianli, 2017-06-16 22:02:01]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 22:02:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jianli, 2017-06-16 22:04:05]

Description was changed from

==========
[Offline Prefetch] Use proto2 syntax for offline prefetch proto

Switching back to proto2 greatly reduced the size.

BUG=733783
==========

to

==========
[Offline Prefetch] Use proto2 syntax for offline prefetch proto

Switching back to proto2 greatly reduced the size. Also moving
the proto definitions in timestamp.proto to where are referenced also saved a
bunch. Note that moving other proto files did not save much.

BUG=733783
==========

[jianli, 2017-06-16 22:04:50]

jianli@chromium.org changed reviewers:
+ dewittj@chromium.org

[dewittj, 2017-06-16 22:37:15]

Are there any semantic differences we need to be aware of? The server team is
using proto3.

[dewittj, 2017-06-16 23:34:44]

otherwise lgtm

[jianli, 2017-06-16 23:36:45]

No. The serialized format remains same.

On Fri, Jun 16, 2017 at 3:37 PM, <dewittj@chromium.org> wrote:

> Are there any semantic differences we need to be aware of? The server team
> is
> using proto3.
>
> https://codereview.chromium.org/2940393002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-06-16 23:48:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 23:48:02]

Dry run: This issue passed the CQ dry run.

[jianli, 2017-06-16 23:52:52]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2017-06-16 23:53:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 23:58:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497657172556590, "parent_rev":
"1ff5a375ab0b3c53a6893a1e257c2d81a16a485b", "commit_rev":
"08ca13d0991463f5646fb88a19460ea2b2778d14"}

[commit-bot: I haz the power, 2017-06-16 23:58:18]

Description was changed from

==========
[Offline Prefetch] Use proto2 syntax for offline prefetch proto

Switching back to proto2 greatly reduced the size. Also moving
the proto definitions in timestamp.proto to where are referenced also saved a
bunch. Note that moving other proto files did not save much.

BUG=733783
==========

to

==========
[Offline Prefetch] Use proto2 syntax for offline prefetch proto

Switching back to proto2 greatly reduced the size. Also moving
the proto definitions in timestamp.proto to where are referenced also saved a
bunch. Note that moving other proto files did not save much.

BUG=733783

Review-Url: https://codereview.chromium.org/2940393002
Cr-Commit-Position: refs/heads/master@{#480230}
Committed:
https://chromium.googlesource.com/chromium/src/+/08ca13d0991463f5646fb88a1946...
==========

[commit-bot: I haz the power, 2017-06-16 23:58:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08ca13d0991463f5646fb88a1946...