Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2940353002: [Payments] Only show shipping option section once there are shipping options (Closed)

Created:
3 years, 6 months ago by gogerald1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, agrieve+watch_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only show shipping option section once there are shipping options BUG=728173 Review-Url: https://codereview.chromium.org/2940353002 Cr-Commit-Position: refs/heads/master@{#480146} Committed: https://chromium.googlesource.com/chromium/src/+/e10aedf65eacdd8b5f31355318a29cdf40e886a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 3 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
gogerald1
Hi rouslan@, ptal,
3 years, 6 months ago (2017-06-16 19:35:22 UTC) #6
please use gerrit instead
lgtm
3 years, 6 months ago (2017-06-16 19:39:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940353002/20001
3 years, 6 months ago (2017-06-16 20:08:45 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 20:14:48 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e10aedf65eacdd8b5f31355318a2...

Powered by Google App Engine
This is Rietveld 408576698