Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2940313002: Move PerformanceTests/Editing/page-up-with-many-lines.html to DOM/ (Closed)

Created:
3 years, 6 months ago by yoichio
Modified:
3 years, 6 months ago
Reviewers:
hayato, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PerformanceTests/Editing/page-up-with-many-lines.html to DOM/ Once I shipped the CL that enabled PerformanceTests/Editing but it was reverted because of bot failures: https://chromium.googlesource.com/chromium/src.git/+/9ddf0ddf5dc89355220874dc29cc9ca1e3501839 Instead of ship all of perf tests under Editing/ at once, I try to ship one by one under DOM directory. BUG=698661 Review-Url: https://codereview.chromium.org/2940313002 Cr-Commit-Position: refs/heads/master@{#482206} Committed: https://chromium.googlesource.com/chromium/src/+/d1c3bd11bf9c9a60812dae6f0500e421e8127023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -24 lines) Patch
A + third_party/WebKit/PerformanceTests/DOM/page-up-with-many-lines.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/PerformanceTests/Editing/page-up-with-many-lines.html View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
yoichio
3 years, 6 months ago (2017-06-16 08:58:09 UTC) #5
yosin_UTC9
lgtm Thanks for doing this!
3 years, 6 months ago (2017-06-16 09:00:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940313002/1
3 years, 6 months ago (2017-06-20 01:39:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/468154)
3 years, 6 months ago (2017-06-20 01:51:34 UTC) #12
yoichio
hayato, PTAL.
3 years, 6 months ago (2017-06-26 05:48:56 UTC) #14
hayato
lgtm
3 years, 6 months ago (2017-06-26 05:53:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940313002/1
3 years, 6 months ago (2017-06-26 05:54:37 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d1c3bd11bf9c9a60812dae6f0500e421e8127023
3 years, 6 months ago (2017-06-26 07:13:45 UTC) #20
rnephew (Reviews Here)
3 years, 5 months ago (2017-06-26 18:38:55 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2960703002/ by rnephew@chromium.org.

The reason for reverting is:
https://bugs.chromium.org/p/chromium/issues/detail?id=736784.

Powered by Google App Engine
This is Rietveld 408576698