Introduce HasVisibleFirstLetter() for CanBeBackwardCaretPosition()

Introduce HasVisibleFirstLetter() for CanBeBackwardCaretPosition()

This patch Introduces |HasVisibleFirstLetter()| to simplify if-statements in
for-loop of CanBeBackwardCaretPosition() for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2940293002
Cr-Commit-Position: refs/heads/master@{#480016}
Committed: https://chromium.googlesource.com/chromium/src/+/22fc506b67c1bc65dead0bd636e84d1a616b9986

[yosin_UTC9, 2017-06-16 06:34:08]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 06:34:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-16 06:36:16]

Description was changed from

==========
2017-06-16T15:29:55

BUG=

2017-06-16T15:29:30
==========

to

==========
Introduce IsVisibleFirstLetter() for CanBeBackwardCaretPosition()

This patch Introduces |IsVisibleFirstLetter()| to simplify if-statements in
for-loop of CanBeBackwardCaretPosition() for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-16 07:44:37]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-06-16 07:44:38]

PTAL

[yoichio, 2017-06-16 07:48:50]

https://codereview.chromium.org/2940293002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right):

https://codereview.chromium.org/2940293002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:1467: bool
IsVisibleFirstLetter(const LayoutText& text_layout_object) {
Function name is "Has"VisibleFirstLetter ?

[yosin_UTC9, 2017-06-16 07:55:53]

Description was changed from

==========
Introduce IsVisibleFirstLetter() for CanBeBackwardCaretPosition()

This patch Introduces |IsVisibleFirstLetter()| to simplify if-statements in
for-loop of CanBeBackwardCaretPosition() for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Introduce HasVisibleFirstLetter() for CanBeBackwardCaretPosition()

This patch Introduces |HasVisibleFirstLetter()| to simplify if-statements in
for-loop of CanBeBackwardCaretPosition() for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-16 07:58:03]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 07:58:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-16 07:58:18]

PTAL

Rename to HasVisibleFirstLetter()

https://codereview.chromium.org/2940293002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right):

https://codereview.chromium.org/2940293002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:1467: bool
IsVisibleFirstLetter(const LayoutText& text_layout_object) {
On 2017/06/16 at 07:48:50, yoichio wrote:
> Function name is "Has"VisibleFirstLetter ?

Done.

[yoichio, 2017-06-16 08:57:22]

lgtm

[yosin_UTC9, 2017-06-16 08:57:44]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-06-16 08:57:46]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-06-16 08:57:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 11:07:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497603466758270,
"parent_rev": "752deed34541bee5b918e583cb7328ce903b15ce", "commit_rev":
"22fc506b67c1bc65dead0bd636e84d1a616b9986"}

[commit-bot: I haz the power, 2017-06-16 11:07:18]

Description was changed from

==========
Introduce HasVisibleFirstLetter() for CanBeBackwardCaretPosition()

This patch Introduces |HasVisibleFirstLetter()| to simplify if-statements in
for-loop of CanBeBackwardCaretPosition() for improving readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Introduce HasVisibleFirstLetter() for CanBeBackwardCaretPosition()

This patch Introduces |HasVisibleFirstLetter()| to simplify if-statements in
for-loop of CanBeBackwardCaretPosition() for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2940293002
Cr-Commit-Position: refs/heads/master@{#480016}
Committed:
https://chromium.googlesource.com/chromium/src/+/22fc506b67c1bc65dead0bd636e8...
==========

[commit-bot: I haz the power, 2017-06-16 11:07:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/22fc506b67c1bc65dead0bd636e8...