Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2940273002: Utilize Find{Left,Right}BoundaryOfEntireBidiRunIgnoringLineBreak() in RenderedPosition (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Utilize Find{Left,Right}BoundaryOfEntireBidiRunIgnoringLineBreak() in RenderedPosition This patch changes |RenderedPosition::{Left,Right}BoundaryOfBidiRun()| to use |Find{Left,Right}BoundaryOfEntireBidiRunIgnoringLineBreak()| to avoid duplicating common pattern for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2940273002 Cr-Commit-Position: refs/heads/master@{#479990} Committed: https://chromium.googlesource.com/chromium/src/+/8fdb190540dab20a6d35b4eb34f8ae7efe37a7d7

Patch Set 1 : 2017-06-16T14:22:58 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -24 lines) Patch
M third_party/WebKit/Source/core/editing/RenderedPosition.cpp View 3 chunks +13 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-16 06:37:17 UTC) #4
yoichio
lgtm
3 years, 6 months ago (2017-06-16 07:54:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940273002/1
3 years, 6 months ago (2017-06-16 08:07:01 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 08:11:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8fdb190540dab20a6d35b4eb34f8...

Powered by Google App Engine
This is Rietveld 408576698