[CRD iOS] Provide a separate system_icons bundle for colliding icons

[CRD iOS] Provide a separate system_icons bundle for colliding icons

This CL puts the refresh icon into a separate bundle so that it doesn't need to
be included by the bling target.

BUG=731851
Review-Url: https://codereview.chromium.org/2940263002
Cr-Commit-Position: refs/heads/master@{#480551}
Committed: https://chromium.googlesource.com/chromium/src/+/0156295a9d7bb6403bd441c487edebbcc2ccfb9a

[Yuwei, 2017-06-16 01:01:30]

yuweih@chromium.org changed reviewers:
+ nicholss@chromium.org

[Yuwei, 2017-06-16 01:01:31]

PTAL thanks!

TBH this still doesn't feel right to me. The piper source doesn't have all
material icons so adding icon in Chromium will always need to check whether the
downstream has the icon and may end up with two CLs in both sides...

I personally think it's fine to just give a remoting_ prefix to the icons since
they are generally small (~16KB per imageset before compression)...

[sdefresne, 2017-06-16 12:55:40]

On 2017/06/16 01:01:31, Yuwei wrote:
> PTAL thanks!
> 
> TBH this still doesn't feel right to me. The piper source doesn't have all
> material icons so adding icon in Chromium will always need to check whether
the
> downstream has the icon and may end up with two CLs in both sides...
> 
> I personally think it's fine to just give a remoting_ prefix to the icons
since
> they are generally small (~16KB per imageset before compression)...

There is a repository http://github.com/google/material-design-icons with all
the icons.

There are discussion for moving Chrome on iOS to use this repository for all the
icons instead of tracking them in the internal repository.

[Yuwei, 2017-06-16 19:46:55]

On 2017/06/16 12:55:40, sdefresne wrote:
> On 2017/06/16 01:01:31, Yuwei wrote:
> > PTAL thanks!
> > 
> > TBH this still doesn't feel right to me. The piper source doesn't have all
> > material icons so adding icon in Chromium will always need to check whether
> the
> > downstream has the icon and may end up with two CLs in both sides...
> > 
> > I personally think it's fine to just give a remoting_ prefix to the icons
> since
> > they are generally small (~16KB per imageset before compression)...
> 
> There is a repository http://github.com/google/material-design-icons with all
> the icons.
> 
> There are discussion for moving Chrome on iOS to use this repository for all
the
> icons instead of tracking them in the internal repository.

Thank you for the information :)

Currently GoogleKit/Web pulls in googlemac/iPhone/Shared/Icons:ic_refresh but we
couldn't use that for the Chromium build. To fix that, we basically want
GoogleKit/Web to either directly or indirectly depend on imageset targets
existed in the Chromium upstream.

[nicholss, 2017-06-19 16:35:54]

lgtm

[Yuwei, 2017-06-19 18:31:38]

Thanks!

[Yuwei, 2017-06-19 18:31:41]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2017-06-19 18:32:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 20:13:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497897101601940,
"parent_rev": "d630381b9a92c6343e7eabf355f09d4e6148030e", "commit_rev":
"0156295a9d7bb6403bd441c487edebbcc2ccfb9a"}

[commit-bot: I haz the power, 2017-06-19 20:13:38]

Description was changed from

==========
[CRD iOS] Provide a separate system_icons bundle for colliding icons

This CL puts the refresh icon into a separate bundle so that it doesn't need to
be included by the bling target.

BUG=731851
==========

to

==========
[CRD iOS] Provide a separate system_icons bundle for colliding icons

This CL puts the refresh icon into a separate bundle so that it doesn't need to
be included by the bling target.

BUG=731851

Review-Url: https://codereview.chromium.org/2940263002
Cr-Commit-Position: refs/heads/master@{#480551}
Committed:
https://chromium.googlesource.com/chromium/src/+/0156295a9d7bb6403bd441c487ed...
==========

[commit-bot: I haz the power, 2017-06-19 20:13:40]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0156295a9d7bb6403bd441c487ed...