Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 294023016: Revert of Modify sample buffer size for larger displays. (Closed)

Created:
6 years, 7 months ago by scroggo
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com, epoger
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Modify sample buffer size for larger displays. (https://codereview.chromium.org/240433002/) Reason for revert: This also changes verylargebitmap, and the difference appears to be meaningful. Henrik, I have emailed you the images that differ. Original issue's description: > Modify sample buffer size for larger displays. > > Increases the intermediate buffer size for sample pixel indexes, > used in the sample proc function calls. If the operation is bigger > than the buffer it's split into multiple calls, creating overhead. > This would especially impact the performance of SIMD optimizations. > Also, aligns the start address of the buffer to 16 bytes, to enable > more efficient SIMD optimizations. > > Author: henrik.smiding@intel.com > > Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>; > > Committed: http://code.google.com/p/skia/source/detail?r=14825 > > Committed: http://code.google.com/p/skia/source/detail?r=14872 TBR=reed@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -57 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -31 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 3 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scroggo
Created Revert of Modify sample buffer size for larger displays.
6 years, 7 months ago (2014-05-23 19:11:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/294023016/1
6 years, 7 months ago (2014-05-23 19:12:08 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 19:12:09 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-23 19:12:09 UTC) #4
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 7 months ago (2014-05-23 19:13:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/294023016/1
6 years, 7 months ago (2014-05-23 19:13:50 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 19:14:02 UTC) #7
Message was sent while issue was closed.
Change committed as 14878

Powered by Google App Engine
This is Rietveld 408576698