Minor refactor to HandoffManager.

Minor refactor to HandoffManager.

NSUserActivity were being created, and then wrapped in a temporary
base::scoped_nsobject. Instead, immediately wrap in a base::scoped_nsobject on
creation.

BUG=733017
Review-Url: https://codereview.chromium.org/2940193002
Cr-Commit-Position: refs/heads/master@{#480190}
Committed: https://chromium.googlesource.com/chromium/src/+/270e22d3713afcb3fec87282e71ec00e394a2e97

[erikchen, 2017-06-15 21:33:15]

Description was changed from

==========
Fix a memory leak in HandoffManager.

NSUserActivity objects were being leaked because the scoped_nsobject that was
supposed to release them was being used as a rvalue.

BUG=
==========

to

==========
Minor refactor to HandoffManager.

NSUserActivity were being created, and then wrapped in a temporary
base::scoped_nsobject. Instead, immediately wrap in a base::scoped_nsobject on
creation.

BUG=733017
==========

[erikchen, 2017-06-15 21:33:51]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 21:34:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 21:52:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 21:52:29]

Dry run: This issue passed the CQ dry run.

[erikchen, 2017-06-15 21:53:28]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[erikchen, 2017-06-15 21:53:29]

mark: Please review.

[Mark Mentovai, 2017-06-15 21:55:55]

LGTM

[erikchen, 2017-06-16 21:41:43]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-06-16 21:41:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 22:06:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497649303581130, "parent_rev":
"9302b5ae92a433159b8ab89ae77d08a4f253b72f", "commit_rev":
"270e22d3713afcb3fec87282e71ec00e394a2e97"}

[commit-bot: I haz the power, 2017-06-16 22:06:17]

Description was changed from

==========
Minor refactor to HandoffManager.

NSUserActivity were being created, and then wrapped in a temporary
base::scoped_nsobject. Instead, immediately wrap in a base::scoped_nsobject on
creation.

BUG=733017
==========

to

==========
Minor refactor to HandoffManager.

NSUserActivity were being created, and then wrapped in a temporary
base::scoped_nsobject. Instead, immediately wrap in a base::scoped_nsobject on
creation.

BUG=733017

Review-Url: https://codereview.chromium.org/2940193002
Cr-Commit-Position: refs/heads/master@{#480190}
Committed:
https://chromium.googlesource.com/chromium/src/+/270e22d3713afcb3fec87282e71e...
==========

[commit-bot: I haz the power, 2017-06-16 22:06:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/270e22d3713afcb3fec87282e71e...