Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2940143002: Remove the flag --disable-hide-inactive-stacked-tab-close-buttons (Closed)

Created:
3 years, 6 months ago by tdanderson
Modified:
3 years, 6 months ago
Reviewers:
Peter Kasting, pfeldman
CC:
chromium-reviews, tfarina, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the flag --disable-hide-inactive-stacked-tab-close-buttons The behavior of hiding the close buttons on inactive tabs when in stacked tab mode has been on by default for over two years. Remove the flag which disables this behavior. BUG=525058 Review-Url: https://codereview.chromium.org/2940143002 Cr-Commit-Position: refs/heads/master@{#480965} Committed: https://chromium.googlesource.com/chromium/src/+/a42d4c93b5e9dc230e60be8a573912df43a625a7

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -33 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
tdanderson
Peter, can you please take a look?
3 years, 6 months ago (2017-06-15 19:24:05 UTC) #4
Peter Kasting
RS LGTM Yay for removing code!
3 years, 6 months ago (2017-06-15 22:44:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940143002/1
3 years, 6 months ago (2017-06-19 13:47:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/467319)
3 years, 6 months ago (2017-06-19 13:54:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940143002/20001
3 years, 6 months ago (2017-06-20 19:49:05 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/468909)
3 years, 6 months ago (2017-06-20 20:00:58 UTC) #16
tdanderson
pfeldman@, can you please take a look at content/ ?
3 years, 6 months ago (2017-06-20 20:03:50 UTC) #18
pfeldman
lgtm
3 years, 6 months ago (2017-06-20 20:21:41 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940143002/20001
3 years, 6 months ago (2017-06-20 20:51:34 UTC) #21
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 21:33:56 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a42d4c93b5e9dc230e60be8a5739...

Powered by Google App Engine
This is Rietveld 408576698