Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2940103003: login: Remove scoped keyboard disabler. (Closed)

Created:
3 years, 6 months ago by sammiequon
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, blakeo+virtualkb_chromium.org, alemate+watch_chromium.org, oka+watchvk_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, yhanada+watchvk_chromium.org, dfaden+virtualkb_google.com, groby+virtualkb_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

login: Remove scoped keyboard disabler. Pin keyboard uses scoped keyboard disabler (added in https://codereview.chromium.org/2444443002/) to prevent the VK from popping up when pin numbers are tapped. Wrapping focus calls has been resupported after https://codereview.chromium.org/2699533009, so use this instead. TEST=manual BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Add closure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -131 lines) Patch
M chrome/browser/resources/chromeos/quick_unlock/compiled_resources2.gyp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.js View 3 chunks +19 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js View 3 chunks +19 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
D ui/keyboard/scoped_keyboard_disabler.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ui/keyboard/scoped_keyboard_disabler.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M ui/login/account_picker/md_user_pod_row.js View 3 chunks +0 lines, -17 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (10 generated)
sammiequon
3 years, 5 months ago (2017-06-30 21:11:51 UTC) #11
On 2017/06/15 21:04:17, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Done on gerrit.

Powered by Google App Engine
This is Rietveld 408576698