Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: ui/login/account_picker/md_user_pod_row.js

Issue 2940103003: login: Remove scoped keyboard disabler. (Closed)
Patch Set: Add closure. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/keyboard/scoped_keyboard_disabler.cc ('k') | ui/login/account_picker/user_pod_row.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/login/account_picker/md_user_pod_row.js
diff --git a/ui/login/account_picker/md_user_pod_row.js b/ui/login/account_picker/md_user_pod_row.js
index 6d6b0b010ad8ccd3a8124f67c244b05a2d27e174..b0802dbe914164677b283aa8a4942a17a96fc790 100644
--- a/ui/login/account_picker/md_user_pod_row.js
+++ b/ui/login/account_picker/md_user_pod_row.js
@@ -802,8 +802,6 @@ cr.define('login', function() {
this.handlePasswordKeyPress_.bind(this));
this.passwordElement.addEventListener('input',
this.handleInputChanged_.bind(this));
- this.passwordElement.addEventListener('mouseup',
- this.handleInputMouseUp_.bind(this));
if (this.submitButton) {
this.submitButton.addEventListener('click',
@@ -1314,8 +1312,6 @@ cr.define('login', function() {
// Adjust the vertical position based on the pin keyboard visibility.
var podHeight = visible ? CROS_POD_HEIGHT_WITH_PIN : CROS_POD_HEIGHT;
this.top = ($('pod-row').screenSize.height - podHeight) / 2;
-
- chrome.send('setForceDisableVirtualKeyboard', [visible]);
},
isPinShown: function() {
@@ -2075,19 +2071,6 @@ cr.define('login', function() {
this.updateInput_();
},
- /**
- * Handles mouse up event on the password element.
- * @param {Event} e Mouse up event.
- */
- handleInputMouseUp_: function(e) {
- // If the PIN keyboard is shown and the user clicks on the password
- // element, the virtual keyboard should pop up if it is enabled, so we
- // must disable the virtual keyboard override.
- if (this.isPinShown()) {
- chrome.send('setForceDisableVirtualKeyboard', [false]);
- }
- },
-
/**
* Handles click event on a user pod.
* @param {Event} e Click event.
« no previous file with comments | « ui/keyboard/scoped_keyboard_disabler.cc ('k') | ui/login/account_picker/user_pod_row.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698