Add timestamp to infobar for stale Previews

chrome/browser/previews/previews_infobar_delegate.h

Index: chrome/browser/previews/previews_infobar_delegate.h
diff --git a/chrome/browser/previews/previews_infobar_delegate.h b/chrome/browser/previews/previews_infobar_delegate.h
index 0979c07e2b7efef2d24c351b166d14eea62abf51..3b743b927a733a2b36d0233eda30fd3b040f10dd 100644
--- a/chrome/browser/previews/previews_infobar_delegate.h
+++ b/chrome/browser/previews/previews_infobar_delegate.h
@@ -7,6 +7,7 @@
 
 #include "base/callback.h"
 #include "base/strings/string16.h"
+#include "base/time/time.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "components/previews/core/previews_experiments.h"
 
@@ -41,10 +42,12 @@ class PreviewsInfoBarDelegate : public ConfirmInfoBarDelegate {
   static void Create(
       content::WebContents* web_contents,
       previews::PreviewsType previews_type,
+      base::Time previews_freshness,
       bool is_data_saver_user,
       const OnDismissPreviewsInfobarCallback& on_dismiss_callback);
 
   // ConfirmInfoBarDelegate overrides:
+  int GetIconId() const override;
   base::string16 GetMessageText() const override;
   base::string16 GetLinkText() const override;
 
@@ -54,18 +57,19 @@ class PreviewsInfoBarDelegate : public ConfirmInfoBarDelegate {
   PreviewsInfoBarDelegate(
       content::WebContents* web_contents,
       previews::PreviewsType previews_type,
+      base::Time previews_freshness,
       bool is_data_saver_user,
       const OnDismissPreviewsInfobarCallback& on_dismiss_callback);
 
   // ConfirmInfoBarDelegate overrides:
   infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
-  int GetIconId() const override;
   bool ShouldExpire(const NavigationDetails& details) const override;
   void InfoBarDismissed() override;
   int GetButtons() const override;
   bool LinkClicked(WindowOpenDisposition disposition) override;
 
   previews::PreviewsType previews_type_;
+  base::Time previews_freshness_;

[tbansal1, 2017/06/19 20:52:29]

Can this be a const variable?

[tbansal1, 2017/06/19 20:52:29]

Add a variable comment?
Seems like this is the time when preview was created?
Also, it might be useful to comment that a value of 0 implies that creation time
is unknown.

[megjablon, 2017/06/20 18:42:12]

Done.

   mutable PreviewsInfoBarAction infobar_dismissed_action_;
 
   const base::string16 message_text_;