Add timestamp to infobar for stale Previews

chrome/browser/previews/previews_infobar_delegate.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PREVIEWS_PREVIEWS_INFOBAR_DELEGATE_H_
 #define CHROME_BROWSER_PREVIEWS_PREVIEWS_INFOBAR_DELEGATE_H_
 
 #include "base/callback.h"
 #include "base/strings/string16.h"
+#include "base/time/time.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "components/previews/core/previews_experiments.h"
 
 namespace content {
 class WebContents;
 }
 
 // Shows an infobar that lets the user know that a preview page has been loaded,
 // and gives the user a link to reload the original page. This infobar will only
 // be shown once per page load. Records UMA data for user interactions with the
@@ skipping 14 matching lines @@
     INFOBAR_INDEX_BOUNDARY
   };
 
   ~PreviewsInfoBarDelegate() override;
 
   // Creates a preview infobar and corresponding delegate and adds the infobar
   // to InfoBarService.
   static void Create(
       content::WebContents* web_contents,
       previews::PreviewsType previews_type,
+      base::Time previews_freshness,
       bool is_data_saver_user,
       const OnDismissPreviewsInfobarCallback& on_dismiss_callback);
 
   // ConfirmInfoBarDelegate overrides:
+  int GetIconId() const override;
   base::string16 GetMessageText() const override;
   base::string16 GetLinkText() const override;
 
   base::string16 GetTimestampText() const;
 
  private:
   PreviewsInfoBarDelegate(
       content::WebContents* web_contents,
       previews::PreviewsType previews_type,
+      base::Time previews_freshness,
       bool is_data_saver_user,
       const OnDismissPreviewsInfobarCallback& on_dismiss_callback);
 
   // ConfirmInfoBarDelegate overrides:
   infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
-  int GetIconId() const override;
   bool ShouldExpire(const NavigationDetails& details) const override;
   void InfoBarDismissed() override;
   int GetButtons() const override;
   bool LinkClicked(WindowOpenDisposition disposition) override;
 
   previews::PreviewsType previews_type_;
+  base::Time previews_freshness_;

[tbansal1, 2017/06/19 20:52:29]

Can this be a const variable?

[tbansal1, 2017/06/19 20:52:29]

Add a variable comment?
Seems like this is the time when preview was created?
Also, it might be useful to comment that a value of 0 implies that creation time
is unknown.

[megjablon, 2017/06/20 18:42:12]

Done.

   mutable PreviewsInfoBarAction infobar_dismissed_action_;
 
   const base::string16 message_text_;
 
   OnDismissPreviewsInfobarCallback on_dismiss_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(PreviewsInfoBarDelegate);
 };
 
 #endif  // CHROME_BROWSER_PREVIEWS_PREVIEWS_INFOBAR_DELEGATE_H_