Revert of Removes usage of signin APIs that return scoped_nsobjects.

Revert of Removes usage of signin APIs that return scoped_nsobjects. (patchset #4 id:60001 of https://codereview.chromium.org/2920853006/ )

Reason for revert:
This broke ios_chrome_settings_egtests
AccountCollectionsTest
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad9-simulator-x64/builds/12286/steps/ios_chrome_settings_egtests%20%28iPad%20Air%20iOS%209.0%29%20on%20Mac/logs/stdio


Original issue's description:
> Removes usage of signin APIs that return scoped_nsobjects.
> 
> Returning scoped_nsobjects is against the philosophy of autoreleased
> objects being passed around. Refactoring methods and functions vending
> scoped_nsobjects allows for a cleaner transition to ARC later.
> 
> This is CL 3/5.
> 
> BUG=None
> TEST=None
> 
> Review-Url: https://codereview.chromium.org/2920853006
> Cr-Commit-Position: refs/heads/master@{#479691}
> Committed: https://chromium.googlesource.com/chromium/src/+/f46f8cdc0ebf789cc6be1ee524955cef93229111

TBR=msarda@chromium.org,lpromero@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2940063004
Cr-Commit-Position: refs/heads/master@{#479877}
Committed: https://chromium.googlesource.com/chromium/src/+/dbcd6a71e427f5dbb0a688851c6ccb263db2b002

[mrefaat, 2017-06-15 22:38:53]

The CQ bit was checked by mrefaat@chromium.org

[mrefaat, 2017-06-15 22:38:54]

Created Revert of Removes usage of signin APIs that return scoped_nsobjects.

[commit-bot: I haz the power, 2017-06-15 22:39:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 22:39:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 22:39:26]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[sczs, 2017-06-15 22:42:49]

sczs@chromium.org changed reviewers:
+ sczs@chromium.org

[sczs, 2017-06-15 22:42:49]

lgtm

[mrefaat, 2017-06-15 22:43:53]

The CQ bit was checked by mrefaat@chromium.org

[commit-bot: I haz the power, 2017-06-15 22:44:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 22:44:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497566633177920, "parent_rev":
"48ce5bedd14179df1bfd70ff5e8e49ec92288a56", "commit_rev":
"dbcd6a71e427f5dbb0a688851c6ccb263db2b002"}

[commit-bot: I haz the power, 2017-06-15 22:45:07]

Description was changed from

==========
Revert of Removes usage of signin APIs that return scoped_nsobjects. (patchset
#4 id:60001 of https://codereview.chromium.org/2920853006/ )

Reason for revert:
This broke ios_chrome_settings_egtests
AccountCollectionsTest
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad9-sim...


Original issue's description:
> Removes usage of signin APIs that return scoped_nsobjects.
> 
> Returning scoped_nsobjects is against the philosophy of autoreleased
> objects being passed around. Refactoring methods and functions vending
> scoped_nsobjects allows for a cleaner transition to ARC later.
> 
> This is CL 3/5.
> 
> BUG=None
> TEST=None
> 
> Review-Url: https://codereview.chromium.org/2920853006
> Cr-Commit-Position: refs/heads/master@{#479691}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f46f8cdc0ebf789cc6be1ee52495...

TBR=msarda@chromium.org,lpromero@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
==========

to

==========
Revert of Removes usage of signin APIs that return scoped_nsobjects. (patchset
#4 id:60001 of https://codereview.chromium.org/2920853006/ )

Reason for revert:
This broke ios_chrome_settings_egtests
AccountCollectionsTest
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad9-sim...


Original issue's description:
> Removes usage of signin APIs that return scoped_nsobjects.
> 
> Returning scoped_nsobjects is against the philosophy of autoreleased
> objects being passed around. Refactoring methods and functions vending
> scoped_nsobjects allows for a cleaner transition to ARC later.
> 
> This is CL 3/5.
> 
> BUG=None
> TEST=None
> 
> Review-Url: https://codereview.chromium.org/2920853006
> Cr-Commit-Position: refs/heads/master@{#479691}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f46f8cdc0ebf789cc6be1ee52495...

TBR=msarda@chromium.org,lpromero@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2940063004
Cr-Commit-Position: refs/heads/master@{#479877}
Committed:
https://chromium.googlesource.com/chromium/src/+/dbcd6a71e427f5dbb0a688851c6c...
==========

[commit-bot: I haz the power, 2017-06-15 22:45:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbcd6a71e427f5dbb0a688851c6c...

[scottmg, 2017-06-15 23:14:48]

Hi, it looks like this revert has conflicted, maybe with some of the pipelined
changes? 

ios trunk is currently broken and this is blocking the CQ e.g.
https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/18542 .