Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2940053003: Refactor NextLeafWithSameEditability() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor NextLeafWithSameEditability() This patch converts while-loop to for-loop in |NextLeafWithSameEditability()| to avoid modifying parameter for improving code health. This patch is similar to the patch[1] which does same thing for |PreviousLeafWithSameEditability()|. [1] http://crrev.com/2942833002: Refactor PreviousLeafWithSameEditability() BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2940053003 Cr-Commit-Position: refs/heads/master@{#479653} Committed: https://chromium.googlesource.com/chromium/src/+/0a65645aefacca68fa02d16bd41c57f0dbd5aed3

Patch Set 1 : 2017-06-15T16:53:53 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-15 09:01:29 UTC) #5
yoichio
lgtm
3 years, 6 months ago (2017-06-15 09:30:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2940053003/1
3 years, 6 months ago (2017-06-15 09:43:30 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 09:49:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a65645aefacca68fa02d16bd41c...

Powered by Google App Engine
This is Rietveld 408576698