Download cleanup tool based on experiment config and OS bitness

Download cleanup tool based on experiment config and OS bitness

BUG=733358
Review-Url: https://codereview.chromium.org/2939973003
Cr-Commit-Position: refs/heads/master@{#479844}
Committed: https://chromium.googlesource.com/chromium/src/+/53c7aa55ddf22ec531dd4ac58beb558161120519

[veranika, 2017-06-14 18:59:34]

veranika@chromium.org changed reviewers:
+ csharp@chromium.org

[csharp, 2017-06-14 20:14:29]

lgtm

https://codereview.chromium.org/2939973003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc (right):

https://codereview.chromium.org/2939973003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc:78: const
char* architecture = base::win::OSInfo::GetInstance()->architecture() ==
why not string instead of char*?

https://codereview.chromium.org/2939973003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc:91: const
GURL kDownloadRoot(kDownloadRootPath);
nit: I think since these are just const for this call (instead of program life),
the naming scheme should just be download_root and known_good_origin (or at
least that what I've generally seen)

[veranika, 2017-06-15 18:00:20]

https://codereview.chromium.org/2939973003/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc (right):

https://codereview.chromium.org/2939973003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc:78: const
char* architecture = base::win::OSInfo::GetInstance()->architecture() ==
On 2017/06/14 20:14:29, csharp wrote:
> why not string instead of char*?

Done.

https://codereview.chromium.org/2939973003/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc:91: const
GURL kDownloadRoot(kDownloadRootPath);
On 2017/06/14 20:14:29, csharp wrote:
> nit: I think since these are just const for this call (instead of program
life),
> the naming scheme should just be download_root and known_good_origin (or at
> least that what I've generally seen)

Done.

[veranika, 2017-06-15 18:00:28]

The CQ bit was checked by veranika@chromium.org

[veranika, 2017-06-15 18:00:28]

The patchset sent to the CQ was uploaded after l-g-t-m from csharp@chromium.org
Link to the patchset: https://codereview.chromium.org/2939973003/#ps20001
(title: "fix nits")

[commit-bot: I haz the power, 2017-06-15 18:00:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 19:52:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 19:52:44]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[veranika, 2017-06-15 20:03:41]

The CQ bit was checked by veranika@chromium.org

[veranika, 2017-06-15 20:03:41]

The patchset sent to the CQ was uploaded after l-g-t-m from csharp@chromium.org
Link to the patchset: https://codereview.chromium.org/2939973003/#ps40001
(title: "Test fixture's SetUp method should have override")

[commit-bot: I haz the power, 2017-06-15 20:04:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 21:34:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497557021276350,
"parent_rev": "61cdb80e2f8bbdd7091d793eb26fbd983523f288", "commit_rev":
"53c7aa55ddf22ec531dd4ac58beb558161120519"}

[commit-bot: I haz the power, 2017-06-15 21:34:32]

Description was changed from

==========
Download cleanup tool based on experiment config and OS bitness

BUG=733358
==========

to

==========
Download cleanup tool based on experiment config and OS bitness

BUG=733358

Review-Url: https://codereview.chromium.org/2939973003
Cr-Commit-Position: refs/heads/master@{#479844}
Committed:
https://chromium.googlesource.com/chromium/src/+/53c7aa55ddf22ec531dd4ac58beb...
==========

[commit-bot: I haz the power, 2017-06-15 21:34:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/53c7aa55ddf22ec531dd4ac58beb...