Refactor EndOfLineAlgorithm()

Refactor EndOfLineAlgorithm()

This patch utilizes const variable by introducing auxiliary variables and
avoid abbreviation variable names in |EndOfLineAlgorithm()| to improve
readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2939953005
Cr-Commit-Position: refs/heads/master@{#479983}
Committed: https://chromium.googlesource.com/chromium/src/+/2277e9b87e14c9d9782de34ff6ac1151c06894c1

[yosin_UTC9, 2017-06-15 08:22:56]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 08:23:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-15 09:06:30]

Description was changed from

==========
2017-06-15T17:12:34

BUG=

2017-06-15T17:12:19
==========

to

==========
Refactor EndOfLineAlgorithm()

This patch utilizes const variable by introducing auxiliary variables and
avoid abbreviation variable names in |EndOfLineAlgorithm()| to improve
readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-15 09:06:45]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-06-15 09:06:45]

PTAL

[commit-bot: I haz the power, 2017-06-15 10:06:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 10:06:42]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-06-15 18:04:28]

https://codereview.chromium.org/2939953005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp (right):

https://codereview.chromium.org/2939953005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp:408:
EndPositionForLine(adjusted_position, kUseInlineBoxOrdering),
The return value doesn't match the existing code when
|InSameLine(current_position, candidate_position)| is true.

The existing code returns |HonorEditingBoundaryAtOrAfter(candidate_position,
current_position.DeepEquivalent())|.

This patch returns
|HonorEditingBoundaryAtOrAfter(EndPositionForLine(candidate_position,
kUseInlineBoxOrdering), current_position.DeepEquivalent())|.

[yosin_UTC9, 2017-06-16 02:15:40]

PTAL

https://codereview.chromium.org/2939953005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp (right):

https://codereview.chromium.org/2939953005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp:408:
EndPositionForLine(adjusted_position, kUseInlineBoxOrdering),
On 2017/06/15 at 18:04:28, Xiaocheng wrote:
> The return value doesn't match the existing code when
|InSameLine(current_position, candidate_position)| is true.
> 
> The existing code returns |HonorEditingBoundaryAtOrAfter(candidate_position,
current_position.DeepEquivalent())|.
> 
> This patch returns
|HonorEditingBoundaryAtOrAfter(EndPositionForLine(candidate_position,
kUseInlineBoxOrdering), current_position.DeepEquivalent())|.

Oops, you're right.
Updated.

[Xiaocheng, 2017-06-16 03:03:31]

lgtm

[yosin_UTC9, 2017-06-16 03:18:03]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-06-16 03:18:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 07:41:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497583083315870,
"parent_rev": "0721d307c2e650409d287b02ddeeed4d1635b086", "commit_rev":
"2277e9b87e14c9d9782de34ff6ac1151c06894c1"}

[commit-bot: I haz the power, 2017-06-16 07:42:06]

Description was changed from

==========
Refactor EndOfLineAlgorithm()

This patch utilizes const variable by introducing auxiliary variables and
avoid abbreviation variable names in |EndOfLineAlgorithm()| to improve
readability.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Refactor EndOfLineAlgorithm()

This patch utilizes const variable by introducing auxiliary variables and
avoid abbreviation variable names in |EndOfLineAlgorithm()| to improve
readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2939953005
Cr-Commit-Position: refs/heads/master@{#479983}
Committed:
https://chromium.googlesource.com/chromium/src/+/2277e9b87e14c9d9782de34ff6ac...
==========

[commit-bot: I haz the power, 2017-06-16 07:42:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2277e9b87e14c9d9782de34ff6ac...