Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2939943003: Fix testLitePageFallbackViaPagePolicies below M61 (Closed)

Created:
3 years, 6 months ago by Robert Ogden
Modified:
3 years, 6 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org, bustamante
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix testLitePageFallbackViaPagePolicies below M61 BUG=732606 Review-Url: https://codereview.chromium.org/2939943003 Cr-Commit-Position: refs/heads/master@{#479818} Committed: https://chromium.googlesource.com/chromium/src/+/455f6d8c01ce70db7f311a0308e943fc7b612358

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rename decorator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M tools/chrome_proxy/webdriver/decorator_smoke.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/chrome_proxy/webdriver/decorators.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/webdriver/lite_page.py View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Robert Ogden
Ryan, please take a look
3 years, 6 months ago (2017-06-14 21:43:17 UTC) #2
RyanSturm
https://codereview.chromium.org/2939943003/diff/1/tools/chrome_proxy/webdriver/lite_page.py File tools/chrome_proxy/webdriver/lite_page.py (right): https://codereview.chromium.org/2939943003/diff/1/tools/chrome_proxy/webdriver/lite_page.py#newcode172 tools/chrome_proxy/webdriver/lite_page.py:172: @ChromeVersionAfterM(61) Tricky question if this should be 61 or ...
3 years, 6 months ago (2017-06-14 21:49:59 UTC) #3
Robert Ogden
https://codereview.chromium.org/2939943003/diff/1/tools/chrome_proxy/webdriver/lite_page.py File tools/chrome_proxy/webdriver/lite_page.py (right): https://codereview.chromium.org/2939943003/diff/1/tools/chrome_proxy/webdriver/lite_page.py#newcode172 tools/chrome_proxy/webdriver/lite_page.py:172: @ChromeVersionAfterM(61) On 2017/06/14 21:49:58, RyanSturm wrote: > Tricky question ...
3 years, 6 months ago (2017-06-14 21:53:21 UTC) #4
RyanSturm
https://codereview.chromium.org/2939943003/diff/1/tools/chrome_proxy/webdriver/lite_page.py File tools/chrome_proxy/webdriver/lite_page.py (right): https://codereview.chromium.org/2939943003/diff/1/tools/chrome_proxy/webdriver/lite_page.py#newcode172 tools/chrome_proxy/webdriver/lite_page.py:172: @ChromeVersionAfterM(61) On 2017/06/14 21:53:20, Robert Ogden wrote: > On ...
3 years, 6 months ago (2017-06-14 21:55:38 UTC) #5
Robert Ogden
https://codereview.chromium.org/2939943003/diff/1/tools/chrome_proxy/webdriver/lite_page.py File tools/chrome_proxy/webdriver/lite_page.py (right): https://codereview.chromium.org/2939943003/diff/1/tools/chrome_proxy/webdriver/lite_page.py#newcode172 tools/chrome_proxy/webdriver/lite_page.py:172: @ChromeVersionAfterM(61) On 2017/06/14 21:55:38, RyanSturm wrote: > On 2017/06/14 ...
3 years, 6 months ago (2017-06-14 22:33:45 UTC) #6
RyanSturm
lgtm
3 years, 6 months ago (2017-06-15 20:27:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939943003/20001
3 years, 6 months ago (2017-06-15 20:30:11 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 20:41:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/455f6d8c01ce70db7f311a0308e9...

Powered by Google App Engine
This is Rietveld 408576698