Only call TextChanged on existing AXObjects

third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
index 970a804027be2be959290fd30004dc241daeec25..66f7fab3e425f36da16b2d2d11d5a8927627e5dc 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
@@ -585,11 +585,17 @@ void AXObjectCacheImpl::SelectionChanged(Node* node) {
 }
 
 void AXObjectCacheImpl::TextChanged(Node* node) {
-  TextChanged(GetOrCreate(node));
+  AXObjectImpl* axObject = Get(node);
+  if (!axObject)

[dmazzoni, 2017/06/14 18:38:14]

I think you could remove this null-check since TextChanged(AXObjectImpl*)
already does that. Throughout the whole file pretty much all methods allow null
as an argument to keep the code simple.

I'd just write TextChanged(Get(node))

and add a comment saying we don't want to do anything if there's no existing
object because layout may not be clean and/or updatedistribution may be needed

[aboxhall, 2017/06/14 18:46:05]

Great, done.

+    return;
+  TextChanged(axObject);
 }
 
 void AXObjectCacheImpl::TextChanged(LayoutObject* layout_object) {
-  TextChanged(GetOrCreate(layout_object));
+  AXObjectImpl* axObject = Get(layout_object);
+  if (!axObject)

[dmazzoni, 2017/06/14 18:38:14]

Same

[aboxhall, 2017/06/14 18:46:05]

Done.

+    return;
+  TextChanged(axObject);
 }
 
 void AXObjectCacheImpl::TextChanged(AXObjectImpl* obj) {