Added CSSPropertyTransitionPropertyUtils which holds shared parsing logic.

Added CSSPropertyTransitionPropetyUtils which holds shared parsing logic.

NB: CSSPropertyTransitionProperty not to be confused with
CSSPropertyTransition

This patch
- Added CSSPropertyTransitionPropertyUtils .h and .cpp
- Moved ConsumeTransitionProperty and IsValidAnimationPropertyList from
  CSSPropertyParser to CSSPropertyTransitionUtils (changed name of
  IsValidAnimationPropertyList to IsValidAnimationList to avoid confusion
  with the animation property)

This is prework to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyTransitionProperty.

BUG=668012
Review-Url: https://codereview.chromium.org/2939883003
Cr-Commit-Position: refs/heads/master@{#479979}
Committed: https://chromium.googlesource.com/chromium/src/+/8445ae44afda4860ffb44dcab116534b3e3fa4a3

[Bugs Nash, 2017-06-14 05:42:41]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 05:43:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-06-14 05:45:33]

bugsnash@chromium.org changed reviewers:
+ rjwright@chromium.org

[Bugs Nash, 2017-06-14 06:04:19]

Added ConsumeTransitinProperty method

[Bugs Nash, 2017-06-14 06:07:30]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 06:07:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 08:21:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 08:21:01]

Dry run: This issue passed the CQ dry run.

[rjwright, 2017-06-15 04:26:22]

LGTM

This is a very straight-forward change, but do we have any test coverage for
this property?

[alancutter (OOO until 2018), 2017-06-15 04:53:49]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-06-15 04:53:50]

lgtm

On 2017/06/15 at 04:26:22, rjwright wrote:
> LGTM
> 
> This is a very straight-forward change, but do we have any test coverage for
this property?

Yes.
https://cs.chromium.org/search/?q=f:LayoutTests+transition-property&sq=packag...

https://codereview.chromium.org/2939883003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyTransitionPropertyUtils.h
(right):

https://codereview.chromium.org/2939883003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyTransitionPropertyUtils.h:19:
static bool IsValidAnimationPropertyList(const CSSValueList&);
Let's drop the word "Animation" here as it's confusing given the animation
property.

[Bugs Nash, 2017-06-15 05:43:39]

Addressed review

[Bugs Nash, 2017-06-15 05:44:37]

https://codereview.chromium.org/2939883003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyTransitionPropertyUtils.h
(right):

https://codereview.chromium.org/2939883003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyTransitionPropertyUtils.h:19:
static bool IsValidAnimationPropertyList(const CSSValueList&);
On 2017/06/15 at 04:53:49, alancutter wrote:
> Let's drop the word "Animation" here as it's confusing given the animation
property.

done

[Bugs Nash, 2017-06-15 05:44:39]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-06-15 05:44:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjwright@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2939883003/#ps40001
(title: "Addressed review")

[commit-bot: I haz the power, 2017-06-15 05:44:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-06-15 05:49:37]

Description was changed from

==========
Added CSSPropertyTransitionPropetyUtils which holds shared parsing logic.

NB: CSSPropertyTransitionProperty not to be confused with
CSSPropertyTransition

This patch
- Added CSSPropertyTransitionPropertyUtils .h and .cpp
- Moved IsValidAnimationPropertyList from CSSPropertyParser to
  CSSPropertyTransitionUtils

This is prework to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyTransitionProperty.

BUG=668012
==========

to

==========
Added CSSPropertyTransitionPropetyUtils which holds shared parsing logic.

NB: CSSPropertyTransitionProperty not to be confused with
CSSPropertyTransition

This patch
- Added CSSPropertyTransitionPropertyUtils .h and .cpp
- Moved IsValidAnimationPropertyList from CSSPropertyParser to
  CSSPropertyTransitionUtils and changed name to IsValidAnimationList
  to avoid confusion with the animation property

This is prework to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyTransitionProperty.

BUG=668012
==========

[Bugs Nash, 2017-06-15 05:50:56]

Description was changed from

==========
Added CSSPropertyTransitionPropetyUtils which holds shared parsing logic.

NB: CSSPropertyTransitionProperty not to be confused with
CSSPropertyTransition

This patch
- Added CSSPropertyTransitionPropertyUtils .h and .cpp
- Moved IsValidAnimationPropertyList from CSSPropertyParser to
  CSSPropertyTransitionUtils and changed name to IsValidAnimationList
  to avoid confusion with the animation property

This is prework to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyTransitionProperty.

BUG=668012
==========

to

==========
Added CSSPropertyTransitionPropetyUtils which holds shared parsing logic.

NB: CSSPropertyTransitionProperty not to be confused with
CSSPropertyTransition

This patch
- Added CSSPropertyTransitionPropertyUtils .h and .cpp
- Moved ConsumeTransitionProperty and IsValidAnimationPropertyList from
  CSSPropertyParser to CSSPropertyTransitionUtils (changed name of
  IsValidAnimationPropertyList to IsValidAnimationList to avoid confusion
  with the animation property)

This is prework to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyTransitionProperty.

BUG=668012
==========

[commit-bot: I haz the power, 2017-06-15 05:54:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 05:54:59]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Bugs Nash, 2017-06-16 02:57:04]

rebased

[Bugs Nash, 2017-06-16 02:58:02]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-06-16 02:58:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjwright@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2939883003/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2017-06-16 02:58:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 03:11:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 03:11:53]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bugs Nash, 2017-06-16 05:06:53]

fixed build error

[Bugs Nash, 2017-06-16 05:06:55]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-06-16 05:06:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjwright@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2939883003/#ps80001
(title: "fixed build error")

[commit-bot: I haz the power, 2017-06-16 05:07:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 07:15:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497589615365130,
"parent_rev": "3ddd3bc92b1abb19ef0dc36d3cd976bb420c3000", "commit_rev":
"8445ae44afda4860ffb44dcab116534b3e3fa4a3"}

[commit-bot: I haz the power, 2017-06-16 07:16:02]

Description was changed from

==========
Added CSSPropertyTransitionPropetyUtils which holds shared parsing logic.

NB: CSSPropertyTransitionProperty not to be confused with
CSSPropertyTransition

This patch
- Added CSSPropertyTransitionPropertyUtils .h and .cpp
- Moved ConsumeTransitionProperty and IsValidAnimationPropertyList from
  CSSPropertyParser to CSSPropertyTransitionUtils (changed name of
  IsValidAnimationPropertyList to IsValidAnimationList to avoid confusion
  with the animation property)

This is prework to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyTransitionProperty.

BUG=668012
==========

to

==========
Added CSSPropertyTransitionPropetyUtils which holds shared parsing logic.

NB: CSSPropertyTransitionProperty not to be confused with
CSSPropertyTransition

This patch
- Added CSSPropertyTransitionPropertyUtils .h and .cpp
- Moved ConsumeTransitionProperty and IsValidAnimationPropertyList from
  CSSPropertyParser to CSSPropertyTransitionUtils (changed name of
  IsValidAnimationPropertyList to IsValidAnimationList to avoid confusion
  with the animation property)

This is prework to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyTransitionProperty.

BUG=668012

Review-Url: https://codereview.chromium.org/2939883003
Cr-Commit-Position: refs/heads/master@{#479979}
Committed:
https://chromium.googlesource.com/chromium/src/+/8445ae44afda4860ffb44dcab116...
==========

[commit-bot: I haz the power, 2017-06-16 07:16:06]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8445ae44afda4860ffb44dcab116...