Move chrome.fileSystem interface and bindings to //extensions

Move chrome.fileSystem interface and bindings to //extensions

BUG=729713
R=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2939833002
Cr-Commit-Position: refs/heads/master@{#487365}
Committed: https://chromium.googlesource.com/chromium/src/+/8a2484bdca86e285005c653440a4e6e2c30abde2

[michaelpg, 2017-06-13 21:43:46]

Patchset #2 (id:20001) has been deleted

[michaelpg, 2017-06-13 23:19:26]

PTAL. Dependent on the previous CL though.

https://codereview.chromium.org/2939833002/diff/1/extensions/common/api/_perm...
File extensions/common/api/_permission_features.json (right):

https://codereview.chromium.org/2939833002/diff/1/extensions/common/api/_perm...
extensions/common/api/_permission_features.json:250: "extension_types":
["platform_app"]
Devlin, why are these fields necessary when the default_parent in fileSystem has
the same fileds?

[michaelpg, 2017-06-13 23:27:50]

https://codereview.chromium.org/2939833002/diff/1/extensions/common/permissio...
File extensions/common/permissions/extensions_api_permissions.cc (right):

https://codereview.chromium.org/2939833002/diff/1/extensions/common/permissio...
extensions/common/permissions/extensions_api_permissions.cc:66: // the file or
directory is considered consent to read it.
This UI description probably belongs in chrome... somewhere.

[michaelpg, 2017-06-14 05:07:20]

Description was changed from

==========
Move chrome.fileSystem interface and bindings to //extensions

BUG=729713
R=devlin.cronin@chromium.org
==========

to

==========
Move chrome.fileSystem interface and bindings to //extensions

BUG=729713
R=devlin.cronin@chromium.org
==========

[michaelpg, 2017-06-14 05:07:20]

michaelpg@chromium.org changed reviewers:
+ rkc@chromium.org

[michaelpg, 2017-06-14 05:07:42]

michaelpg@chromium.org changed reviewers:
- rkc@chromium.org

[michaelpg, 2017-06-14 05:08:03]

Description was changed from

==========
Move chrome.fileSystem interface and bindings to //extensions

BUG=729713
R=devlin.cronin@chromium.org
==========

to

==========
Move chrome.fileSystem interface and bindings to //extensions

BUG=729713
R=rdevlin.cronin@chromium.org
==========

[michaelpg, 2017-06-14 05:08:03]

michaelpg@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org
- devlin.cronin@chromium.org

[michaelpg, 2017-06-14 05:08:12]

sending to the right account this time

[Devlin, 2017-06-14 14:56:18]

On 2017/06/13 23:19:26, michaelpg wrote:
> PTAL. Dependent on the previous CL though.

Ack; will circle back to this after the dependent CL.

https://codereview.chromium.org/2939833002/diff/1/extensions/common/api/_perm...
File extensions/common/api/_permission_features.json (right):

https://codereview.chromium.org/2939833002/diff/1/extensions/common/api/_perm...
extensions/common/api/_permission_features.json:250: "extension_types":
["platform_app"]
On 2017/06/13 23:19:26, michaelpg wrote:
> Devlin, why are these fields necessary when the default_parent in fileSystem
has
> the same fileds?

They aren't.  Kill them! :)

Optionally, you could do this in a separate CL (either before or after this one)
just in case something breaks (though nothing should).

https://codereview.chromium.org/2939833002/diff/1/extensions/common/api/_perm...
extensions/common/api/_permission_features.json:258: "extension_types":
["platform_app"]
note that this one *is* necessary, since otherwise the QO exception would cause
fileSystem.write to only be available to extension contexts.

[michaelpg, 2017-06-26 18:07:20]

https://codereview.chromium.org/2939833002/diff/1/extensions/common/api/_perm...
File extensions/common/api/_permission_features.json (right):

https://codereview.chromium.org/2939833002/diff/1/extensions/common/api/_perm...
extensions/common/api/_permission_features.json:250: "extension_types":
["platform_app"]
On 2017/06/14 14:56:18, Devlin wrote:
> On 2017/06/13 23:19:26, michaelpg wrote:
> > Devlin, why are these fields necessary when the default_parent in fileSystem
> has
> > the same fileds?
> 
> They aren't.  Kill them! :)
> 
> Optionally, you could do this in a separate CL (either before or after this
one)
> just in case something breaks (though nothing should).

Will do. There's enough custom stuff here that I'll submit it as a separate CL.

[michaelpg, 2017-07-14 02:11:34]

back in SF and getting back to my CLs -- care to take a look? Largely
mechanical.

[michaelpg, 2017-07-17 22:29:22]

friendly ping

[Devlin, 2017-07-17 22:57:34]

lgtm

Just copy-paste, right?

https://codereview.chromium.org/2939833002/diff/100001/extensions/common/api/...
File extensions/common/api/_permission_features.json (right):

https://codereview.chromium.org/2939833002/diff/100001/extensions/common/api/...
extensions/common/api/_permission_features.json:249: "fileSystem.directory": {
Still planning on removing this in a separate CL?

[michaelpg, 2017-07-17 23:00:12]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2017-07-17 23:00:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2017-07-17 23:00:28]

On 2017/07/17 22:57:34, Devlin wrote:
> lgtm
> 
> Just copy-paste, right?

yep

> 
>
https://codereview.chromium.org/2939833002/diff/100001/extensions/common/api/...
> File extensions/common/api/_permission_features.json (right):
> 
>
https://codereview.chromium.org/2939833002/diff/100001/extensions/common/api/...
> extensions/common/api/_permission_features.json:249: "fileSystem.directory": {
> Still planning on removing this in a separate CL?

yep

[commit-bot: I haz the power, 2017-07-18 03:06:57]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1500332412141310,
"parent_rev": "7310f8e993f852c2c5110d00f72f2a882b6fdcf1", "commit_rev":
"044b975f8f5fbf23f79b5fd32c31b7b408bfadf9"}

[commit-bot: I haz the power, 2017-07-18 03:07:10]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1500332412141310,
"parent_rev": "0375ae80fe1d94e9d0fc175ce4312d1b3a6bc168", "commit_rev":
"8a2484bdca86e285005c653440a4e6e2c30abde2"}

[commit-bot: I haz the power, 2017-07-18 03:07:20]

Description was changed from

==========
Move chrome.fileSystem interface and bindings to //extensions

BUG=729713
R=rdevlin.cronin@chromium.org
==========

to

==========
Move chrome.fileSystem interface and bindings to //extensions

BUG=729713
R=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2939833002
Cr-Commit-Position: refs/heads/master@{#487365}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a2484bdca86e285005c653440a4...
==========

[commit-bot: I haz the power, 2017-07-18 03:07:22]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8a2484bdca86e285005c653440a4...