Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 293983011: Set background color for surface view only once in ContentViewRenderView (Closed)

Created:
6 years, 7 months ago by Yusuf
Modified:
6 years, 7 months ago
Reviewers:
Ted C, Sungmann Cho
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Set background color for surface view only once in ContentViewRenderView Right now we set the surface view background color everytime we create a new surface and this causes a white flash everytime the activity is resumed BUG=365589 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yusuf
6 years, 7 months ago (2014-05-21 20:34:55 UTC) #1
Ted C
lgtm
6 years, 7 months ago (2014-05-21 20:44:59 UTC) #2
Yusuf
The CQ bit was checked by yusufo@chromium.org
6 years, 7 months ago (2014-05-21 20:57:56 UTC) #3
Yusuf
The CQ bit was unchecked by yusufo@chromium.org
6 years, 7 months ago (2014-05-21 20:58:41 UTC) #4
Yusuf
sungmann.cho@navercorp.com: can you comment on whether or not the black flash issue you described in ...
6 years, 7 months ago (2014-05-21 21:01:45 UTC) #5
Sungmann Cho
On 2014/05/21 21:01:45, Yusuf wrote: > mailto:sungmann.cho@navercorp.com: > > can you comment on whether or ...
6 years, 7 months ago (2014-05-22 13:07:22 UTC) #6
Yusuf
The CQ bit was checked by yusufo@chromium.org
6 years, 7 months ago (2014-05-22 13:29:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/293983011/1
6 years, 7 months ago (2014-05-22 13:31:34 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 20:45:07 UTC) #9
Message was sent while issue was closed.
Change committed as 272312

Powered by Google App Engine
This is Rietveld 408576698