Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 188203002: Fix a black screen when opening a child Shell. (Closed)

Created:
6 years, 9 months ago by Sungmann Cho
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Fix a black screen when opening a child Shell. The black screen issue at starting frame was fixed a few months ago(https://codereview.chromium.org/92603002). But it seems to work only for the initial Shell. The last patch sets the background color to white, but this value is reset to 0 (black) by the VSyncAdapter after compositing the first frame. So when a child Shell is newly opened, the black screen comes out again. To fix this problem, setSurfaceViewBackgroundColor(Color.WHITE) needs to be moved to surfaceCreated() of SurfaceHolder.Callback. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Sungmann Cho
PTAL :)
6 years, 9 months ago (2014-03-06 00:42:03 UTC) #1
Ted C
lgtm
6 years, 9 months ago (2014-03-06 00:51:28 UTC) #2
powei
lgtm
6 years, 9 months ago (2014-03-06 00:54:57 UTC) #3
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-06 00:55:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/188203002/1
6 years, 9 months ago (2014-03-06 00:55:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:53:39 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275933
6 years, 9 months ago (2014-03-06 01:53:39 UTC) #7
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-06 03:41:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/188203002/1
6 years, 9 months ago (2014-03-06 03:42:59 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 05:37:48 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=276129
6 years, 9 months ago (2014-03-06 05:37:49 UTC) #11
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-06 07:03:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/188203002/1
6 years, 9 months ago (2014-03-06 07:03:57 UTC) #13
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-06 10:19:41 UTC) #14
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 9 months ago (2014-03-06 10:20:03 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 14:12:00 UTC) #16
Message was sent while issue was closed. 
Change committed as 255339

Powered by Google App Engine
This is Rietveld 408576698