Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2939803002: Convert more tests to use the new driver (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -1201 lines) Patch
M pkg/analysis_server/test/analysis/notification_implemented_test.dart View 24 chunks +69 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/integration/coverage.md View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/status_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/util_test.dart View 4 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/index/index_test.dart View 4 chunks +4 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/index/index_unit_test.dart View 8 chunks +7 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 9 chunks +17 lines, -3 lines 0 comments Download
D pkg/analysis_server/test/services/search/search_engine2_test.dart View 1 chunk +0 lines, -297 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 2 chunks +210 lines, -867 lines 0 comments Download
M pkg/analysis_server/test/services/search/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I removed 'search_engine_test.dart' and then renamed 'search_engine2_test.dart' to 'search_engine_test.dart', which causes diff issues, but there ...
3 years, 6 months ago (2017-06-13 18:56:49 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-13 18:59:14 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-13 19:04:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4da838088127703529e6fdb52a4418d5233c3c60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698