Convert more tests to use the new driver

pkg/analysis_server/test/domain_analysis_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analysis_server/protocol/protocol.dart';
 import 'package:analysis_server/protocol/protocol_generated.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
@@ skipping 631 matching lines @@
       code = code.join('\n');
     }
     return code as String;
   }
 }
 
 @reflectiveTest
 class SetSubscriptionsTest extends AbstractAnalysisTest {
   Map<String, List<HighlightRegion>> filesHighlights = {};
 
-  @override
-  bool get enableNewAnalysisDriver => false;
+  Completer _resultsAvailable = new Completer();
 
   void processNotification(Notification notification) {
     if (notification.event == ANALYSIS_HIGHLIGHTS) {
       var params = new AnalysisHighlightsParams.fromNotification(notification);
       filesHighlights[params.file] = params.regions;
+      _resultsAvailable.complete(null);
     }
   }
 
   test_afterAnalysis() async {
     addTestFile('int V = 42;');
     createProject();
     // wait for analysis, no results initially
     await waitForTasksFinished();
     expect(filesHighlights[testFile], isNull);
     // subscribe
     addAnalysisSubscription(AnalysisService.HIGHLIGHTS, testFile);
-    await server.onAnalysisComplete;
+    await _resultsAvailable.future;
     // there are results
     expect(filesHighlights[testFile], isNotEmpty);
   }
 
   test_afterAnalysis_noSuchFile() async {
     String file = '/no-such-file.dart';
     addTestFile('// no matter');
     createProject();
     // wait for analysis, no results initially
     await waitForTasksFinished();
@@ skipping 21 matching lines @@
 main() {
   new A();
 }
 ''');
     createProject();
     // wait for analysis, no results initially
     await waitForTasksFinished();
     expect(filesHighlights[pkgFile], isNull);
     // subscribe
     addAnalysisSubscription(AnalysisService.HIGHLIGHTS, pkgFile);
-    await server.onAnalysisComplete;
+    await _resultsAvailable.future;
     // there are results
     expect(filesHighlights[pkgFile], isNotEmpty);
   }
 
   test_afterAnalysis_packageFile_inRoot() async {
     String pkgA = '/pkgA';
     String pkgB = '/pkgA';
     String pkgFileA = '$pkgA/lib/libA.dart';
     String pkgFileB = '$pkgA/lib/libB.dart';
     resourceProvider.newFile(
@@ skipping 20 matching lines @@
     {
       resourceProvider.newFolder(projectPath);
       handleSuccessfulRequest(
           new AnalysisSetAnalysisRootsParams([pkgA, pkgB], []).toRequest('0'));
     }
     // wait for analysis, no results initially
     await waitForTasksFinished();
     expect(filesHighlights[pkgFileA], isNull);
     // subscribe
     addAnalysisSubscription(AnalysisService.HIGHLIGHTS, pkgFileA);
-    await server.onAnalysisComplete;
+    await _resultsAvailable.future;
     // there are results
     expect(filesHighlights[pkgFileA], isNotEmpty);
   }
 
   test_afterAnalysis_packageFile_notUsed() async {
     String pkgFile = '/packages/pkgA/lib/libA.dart';
     resourceProvider.newFile(
         pkgFile,
         '''
 library lib_a;
 class A {}
 ''');
     resourceProvider.newFile('/project/.packages', 'pkgA:/packages/pkgA/lib');
     //
     addTestFile('// no "pkgA" reference');
     createProject();
     // wait for analysis, no results initially
     await waitForTasksFinished();
     expect(filesHighlights[pkgFile], isNull);
     // make it a priority file, so make analyzable
     server.setPriorityFiles('0', [pkgFile]);
     // subscribe
     addAnalysisSubscription(AnalysisService.HIGHLIGHTS, pkgFile);
-    await server.onAnalysisComplete;
+    await _resultsAvailable.future;
     // there are results
     expect(filesHighlights[pkgFile], isNotEmpty);
   }
 
   test_afterAnalysis_sdkFile() async {
     String file = '/lib/core/core.dart';
     addTestFile('// no matter');
     createProject();
     // wait for analysis, no results initially
     await waitForTasksFinished();
     expect(filesHighlights[file], isNull);
     // subscribe
     addAnalysisSubscription(AnalysisService.HIGHLIGHTS, file);
-    await server.onAnalysisComplete;
+    await _resultsAvailable.future;
     // there are results
     expect(filesHighlights[file], isNotEmpty);
   }
 
   test_beforeAnalysis() async {
     addTestFile('int V = 42;');
     createProject();
     // subscribe
     addAnalysisSubscription(AnalysisService.HIGHLIGHTS, testFile);
     // wait for analysis
@@ skipping 11 matching lines @@
     plugin.AnalysisSetSubscriptionsParams params =
         pluginManager.analysisSetSubscriptionsParams;
     expect(params, isNotNull);
     Map<plugin.AnalysisService, List<String>> subscriptions =
         params.subscriptions;
     expect(subscriptions, hasLength(1));
     List<String> files = subscriptions[plugin.AnalysisService.HIGHLIGHTS];
     expect(files, [testFile]);
   }
 }